Bug 10387

Summary:	checkauth and get_template_and_user have copy-pasta for setting template variables
Product:	Koha	Reporter:	Galen Charlton <gmcharlt>
Component:	Architecture, internals, and plumbing	Assignee:	Galen Charlton <gmcharlt>
Status:	NEW ---	QA Contact:
Severity:	enhancement
Priority:	P5 - low	CC:	dcook, koha, patrick.robitaille
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	---
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:
Circulation function:
Bug Depends on:	9541
Bug Blocks:

Description Galen Charlton 2013-05-31 18:53:50 UTC

Both checkauth and get_template_and_user set a bunch of template variables based on system preferences.  For the vast majority of cases, creating a new default template variable means updating both routines; failing to do this results in bugs like bug 9541.

Setting default template variables should be refactored into a common routine in order to avoid repetition.

Comment 1 Katrin Fischer 2023-07-08 15:49:34 UTC

Can someone tell if this is still valid?

Comment 2 David Cook 2024-11-05 23:22:40 UTC

(In reply to Katrin Fischer from comment #1)
> Can someone tell if this is still valid?

Yes, although the solution is more to move to using the system preference template plugin. 

It's long tedious work but needs to be done eventually.