Bug 10387 - checkauth and get_template_and_user have copy-pasta for setting template variables
Summary: checkauth and get_template_and_user have copy-pasta for setting template vari...
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Galen Charlton
QA Contact:
URL:
Keywords:
Depends on: 9541
Blocks:
  Show dependency treegraph
 
Reported: 2013-05-31 18:53 UTC by Galen Charlton
Modified: 2023-07-08 15:49 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Galen Charlton 2013-05-31 18:53:50 UTC
Both checkauth and get_template_and_user set a bunch of template variables based on system preferences.  For the vast majority of cases, creating a new default template variable means updating both routines; failing to do this results in bugs like bug 9541.

Setting default template variables should be refactored into a common routine in order to avoid repetition.
Comment 1 Katrin Fischer 2023-07-08 15:49:34 UTC
Can someone tell if this is still valid?