Summary: | Remove obsolete Z3950 module and test | ||
---|---|---|---|
Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
Component: | Z39.50 / SRU / OpenSearch Servers | Assignee: | Marcel de Rooy <m.de.rooy> |
Status: | CLOSED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | bgkriegel, chrish, dcook, gmcharlt, jonathan.druart, m.de.rooy |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 10458: Remove obsolete Z3950 module and test
Bug 10458: Remove obsolete Z3950 module and test Bug 10458: Remove obsolete Z3950 module and test Bug 10458: t/Z3950.t should be removed too |
Description
Marcel de Rooy
2013-06-13 08:25:35 UTC
Created attachment 18912 [details] [review] Bug 10458: Remove obsolete Z3950 module and test Are not used. Contain several FIXMEs. Removing them makes life easier. Test plan: Actually, you cannot test this. But for confidence: do a Z3950 search in cataloguing and acquisition. Created attachment 18984 [details] [review] Bug 10458: Remove obsolete Z3950 module and test Are not used. Contain several FIXMEs. Removing them makes life easier. Test plan: Actually, you cannot test this. But for confidence: do a Z3950 search in cataloguing and acquisition. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> QA comment: I agree with this patch. I didn't find any possible regressions. You forgot the t/Z3950.t file, I will submit a followup. Marked as Passed QA. Created attachment 19003 [details] [review] Bug 10458: Remove obsolete Z3950 module and test Are not used. Contain several FIXMEs. Removing them makes life easier. Test plan: Actually, you cannot test this. But for confidence: do a Z3950 search in cataloguing and acquisition. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Created attachment 19004 [details] [review] Bug 10458: t/Z3950.t should be removed too Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Note: the qa tests don't work with this patch. I find a limitation (commit only deletes files). Thank Marcel for that! :) This is high up on my list of favorite types of patches. Pushed to master. Thanks, Marcel and Jonathan! This has been already pushed to 3.12.x Pushed to 3.10.x, will be in 3.10.8 Pushed to 3.8.x, will be in 3.8.15 *** Bug 10211 has been marked as a duplicate of this bug. *** |