Bug 10507

Summary: Typo when warning about creating duplicate patron attribute
Product: Koha Reporter: Chris Dixon <christopher.dixon>
Component: PatronsAssignee: Colin Campbell <colin.campbell>
Status: CLOSED FIXED QA Contact:
Severity: trivial    
Priority: P5 - low CC: bgkriegel, chrish, colin.campbell, gmcharlt, kyle.m.hall, tomascohen
Version: 3.10   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Proposed patch
[SIGNED-OFF] Bug 10507 Fix namespace collision in patron entry
Bug 10507 Fix namespace collision in patron entry

Description Chris Dixon 2013-06-25 23:44:13 UTC
The warning reads like this: "The attribute value 1 is already is use by another patron record"
Comment 1 Colin Campbell 2013-07-09 10:39:42 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2013-07-09 12:18:08 UTC Comment hidden (obsolete)
Comment 3 Kyle M Hall 2013-07-12 17:07:09 UTC
Created attachment 19608 [details] [review]
Bug 10507 Fix namespace collision in patron entry

If a warning about a duplicated patron attribute is returned
the value was being passed back for display in the warning
message with the same name as the variable in errors

as the message is displayed in the context of errors
the error value 1 was being displayed not the value
duplicated as intended.
Pass the value to the template with a unique name

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

I fixed another tiny typo while signing off: "is already in use" instead
of "is already is use."

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Passes koha-qa.pl, works as advertised.
Comment 4 Galen Charlton 2013-07-12 20:58:33 UTC
Pushed to master.  Thanks, Colin!
Comment 5 Tomás Cohen Arazi 2013-07-16 20:03:26 UTC
This patch has been pushed to 3.12.x, will be in 3.12.2.

Thanks Colin!
Comment 6 Bernardo Gonzalez Kriegel 2013-08-04 19:58:49 UTC
Pushed to 3.10.x, will be in 3.10.10
Comment 7 Chris Hall 2013-09-16 08:44:26 UTC
Pushed to 3.8.x, will be in 3.8.18