Bug 10511

Summary: Odd behavior for messaging preferences with Talking Tech enabled
Product: Koha Reporter: Kyle M Hall <kyle>
Component: PatronsAssignee: Kyle M Hall <kyle>
Status: CLOSED FIXED QA Contact: Jonathan Druart <jonathan.druart>
Severity: minor    
Priority: P5 - low CC: bgkriegel, gmcharlt, jonathan.druart, kyle.m.hall, tomascohen
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 10511 - Odd behavior for messaging preferences with Talking Tech enabled
[SIGNED-OFF] Bug 10511 - Odd behavior for messaging preferences with Talking Tech enabled
Bug 10511 - Odd behavior for messaging preferences with Talking Tech enabled - QA Followup
Bug 10511 - Odd behavior for messaging preferences with Talking Tech enabled
Bug 10511 - Odd behavior for messaging preferences with Talking Tech enabled - QA Followup

Description Kyle M Hall 2013-06-26 20:40:04 UTC
An error in the onclick for phone notices causes the "Do not notify" checkbox to be checked when the phone checkbox is checked. Also, checking "Do not notify" does not uncheck the phone checkbox.
Comment 1 Kyle M Hall 2013-06-26 20:43:49 UTC Comment hidden (obsolete)
Comment 2 Srdjan Jankovic 2013-07-19 03:57:42 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2013-07-19 11:52:28 UTC
QA comment:

removeAttr takes only 1 parameter.

Marked as Failed QA.
Comment 4 Kyle M Hall 2013-07-22 12:33:08 UTC Comment hidden (obsolete)
Comment 5 Jonathan Druart 2013-08-12 13:10:03 UTC
QA comment:

The described ergonomic issue has been fixed.

Marked as Passed QA.
Comment 6 Jonathan Druart 2013-08-12 13:10:28 UTC
Created attachment 20271 [details] [review]
Bug 10511 - Odd behavior for messaging preferences with Talking Tech enabled

An error in the onclick for phone notices causes the "Do not notify"
checkbox to be checked when the phone checkbox is checked. Also,
checking "Do not notify" does not uncheck the phone checkbox.

Test plan:
1) Enable TalkingTechItivaPhoneNotification
2) Browse to the new patron screen ( memberentry.pl )
3) In the patron messaging preferences check the Phone checkbox
4) Not the "do not notify" checkbox is then checked
5) Uncheck the "do not notify" checkbox, and check the Email checkbox as well
6) Now check the "do not notify" checkbox, note the Phone checkbox remains checked
7) Apply this patch
8) Repeat steps 3-6, noting the odd behavior is no longer present

Signed-off-by: Srdjan <srdjan@catalyst.net.nz>

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 7 Jonathan Druart 2013-08-12 13:10:55 UTC
Created attachment 20272 [details] [review]
Bug 10511 - Odd behavior for messaging preferences with Talking Tech enabled - QA Followup

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 8 Galen Charlton 2013-08-12 14:14:22 UTC
Pushed to master.  Thanks, Kyle!
Comment 9 Tomás Cohen Arazi 2013-09-10 17:31:20 UTC
This patch has been pushed to 3.12.x, will be in 3.12.5.

Thanks Kyle!
Comment 10 Bernardo Gonzalez Kriegel 2013-09-14 19:13:32 UTC
Pushed to 3.10.x, will be in 3.10.11