Bug 10550

Summary:	Fix database typo wthdrawn
Product:	Koha	Reporter:	Katrin Fischer <katrin.fischer>
Component:	Architecture, internals, and plumbing	Assignee:	Kyle M Hall (khall) <kyle>
Status:	CLOSED FIXED	QA Contact:	Jonathan Druart <jonathan.druart>
Severity:	normal
Priority:	P5 - low	CC:	bgkriegel, gmcharlt, jonathan.druart, kyle, vanoudt
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	---
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:
Circulation function:
Bug Depends on:
Bug Blocks:	9673, 12871
Attachments:	Bug 10550 - Fix database typo wthdrawn Bug 10550 - Fix database typo wthdrawn Bug 10550 - Fix database typo wthdrawn Bug 10550 - Fix database typo wthdrawn [SIGNED-OFF] Bug 10550 - Fix database typo wthdrawn Bug 10550 - Fix database typo wthdrawn Bug 10550: Merge 2 updatedatabase entries into 1

Description Katrin Fischer 2013-07-07 09:53:59 UTC

Citing Galen's mail from May 22nd:

However, now that we're at the very beginning of the 3.14 cycle, the window is now open for the sort of patch that offers cosmetic or textual improvement but which also happens to touch a lot of code.  If there are longstanding typos you want to fix (my "favorite" is the wthdrawn column in the items table), now is your chance.  I'm not setting a definite end to the window at this point, but suffice it to say that I will be much more likely to merge such patches now as opposed to three months from now.



Time is running ;)

Comment 1 Kyle M Hall (khall) 2013-07-08 16:01:23 UTC Comment hidden (obsolete)

Created attachment 19480 [details] [review]
Bug 10550 - Fix database typo wthdrawn

This patch updates the wthdrawn field in items and deleteditems to be withdrawn
instead. No functional changes are made.

Comment 2 Kyle M Hall (khall) 2013-07-08 16:06:13 UTC Comment hidden (obsolete)

Created attachment 19481 [details] [review]
Bug 10550 - Fix database typo wthdrawn

This patch updates the wthdrawn field in items and deleteditems to be
withdrawn instead. No functional changes are made.

Comment 3 Katrin Fischer 2013-07-08 23:09:10 UTC

Should we also be nice and update saved reports using wthdrawn?

Comment 4 Kyle M Hall (khall) 2013-07-09 10:28:19 UTC

I think that's a good and sensible idea!

Comment 5 Kyle M Hall (khall) 2013-07-09 10:49:19 UTC Comment hidden (obsolete)

Created attachment 19502 [details] [review]
Bug 10550 - Fix database typo wthdrawn

This patch updates the wthdrawn field in items and deleteditems to be
withdrawn instead. No functional changes are made.

Comment 6 Bernardo Gonzalez Kriegel 2013-08-07 00:00:25 UTC

Kyle,
all seems allright, but on loaded frameworks we still have incorrect values,
I think we need something like

UPDATE marc_subfield_structure SET kohafield = 'items.withdrawn' WHERE kohafield = 'items.wthdrawn';

Regards

Comment 7 Katrin Fischer 2013-08-07 08:11:16 UTC

Thx Bernardo for spotting this!

Comment 8 Kyle M Hall (khall) 2013-08-07 12:14:41 UTC

Indeed, good catch!

Comment 9 Kyle M Hall (khall) 2013-08-08 17:16:26 UTC Comment hidden (obsolete)

Created attachment 20178 [details] [review]
Bug 10550 - Fix database typo wthdrawn

This patch updates the wthdrawn field in items and deleteditems to be
withdrawn instead. No functional changes are made.

Comment 10 Bernardo Gonzalez Kriegel 2013-08-08 18:13:24 UTC Comment hidden (obsolete)

Created attachment 20179 [details] [review]
[SIGNED-OFF] Bug 10550 - Fix database typo wthdrawn

This patch updates the wthdrawn field in items and deleteditems to be
withdrawn instead. No functional changes are made.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>

Comment: Save for translation files (that will be fixed on next release),
only occurrence of wthdrawn is on updatedatabase.pl
No koha-qa errors.

This touch many files, and I did not test everything,
but all seems normal. I think that any problem could
be fixed later.

Perhaps both entries in updatedatabase.pl could be joined
into one, but thats for QA.

Comment 11 Jonathan Druart 2013-08-19 13:09:28 UTC

QA comment:

All looks good.

Note that 1 authorized value named "WTHDRAWN" still exists.

Marked as Passed QA.

Comment 12 Jonathan Druart 2013-08-19 13:09:48 UTC

Created attachment 20457 [details] [review]
Bug 10550 - Fix database typo wthdrawn

This patch updates the wthdrawn field in items and deleteditems to be
withdrawn instead. No functional changes are made.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>

Comment: Save for translation files (that will be fixed on next release),
only occurrence of wthdrawn is on updatedatabase.pl
No koha-qa errors.

This touch many files, and I did not test everything,
but all seems normal. I think that any problem could
be fixed later.

Perhaps both entries in updatedatabase.pl could be joined
into one, but thats for QA.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>

Comment 13 Jonathan Druart 2013-08-19 13:09:53 UTC

Created attachment 20458 [details] [review]
Bug 10550: Merge 2 updatedatabase entries into 1

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>

Comment 14 Galen Charlton 2013-09-08 02:05:25 UTC

Pushed to master, along with a couple follow-ups.  Thanks, Kyle!

Comment 15 Jonathan Druart 2013-09-09 07:46:47 UTC

Added to qa tools:
commit c90d0c5e5436daec23d2c6e21e5759e8344ad1f5
Author:     Jonathan Druart <jonathan.druart@biblibre.com>
AuthorDate: Mon Sep 9 09:45:10 2013 +0200
    wthdrawn is a typo (see bug 10550).

Comment 16 Katrin Fischer 2013-09-09 08:19:33 UTC

Thx Jonathan!

Comment 17 Nicholas van Oudtshoorn 2015-06-18 06:11:46 UTC

Just to note that the MARC frameworks on the wiki ( http://wiki.koha-community.org/wiki/MARC_frameworks ) weren't updated with this bug. It's now done.

Comment 18 Katrin Fischer 2015-06-21 10:41:28 UTC

Thx Nicholas!