Citing Galen's mail from May 22nd: However, now that we're at the very beginning of the 3.14 cycle, the window is now open for the sort of patch that offers cosmetic or textual improvement but which also happens to touch a lot of code. If there are longstanding typos you want to fix (my "favorite" is the wthdrawn column in the items table), now is your chance. I'm not setting a definite end to the window at this point, but suffice it to say that I will be much more likely to merge such patches now as opposed to three months from now. Time is running ;)
Created attachment 19480 [details] [review] Bug 10550 - Fix database typo wthdrawn This patch updates the wthdrawn field in items and deleteditems to be withdrawn instead. No functional changes are made.
Created attachment 19481 [details] [review] Bug 10550 - Fix database typo wthdrawn This patch updates the wthdrawn field in items and deleteditems to be withdrawn instead. No functional changes are made.
Should we also be nice and update saved reports using wthdrawn?
I think that's a good and sensible idea!
Created attachment 19502 [details] [review] Bug 10550 - Fix database typo wthdrawn This patch updates the wthdrawn field in items and deleteditems to be withdrawn instead. No functional changes are made.
Kyle, all seems allright, but on loaded frameworks we still have incorrect values, I think we need something like UPDATE marc_subfield_structure SET kohafield = 'items.withdrawn' WHERE kohafield = 'items.wthdrawn'; Regards
Thx Bernardo for spotting this!
Indeed, good catch!
Created attachment 20178 [details] [review] Bug 10550 - Fix database typo wthdrawn This patch updates the wthdrawn field in items and deleteditems to be withdrawn instead. No functional changes are made.
Created attachment 20179 [details] [review] [SIGNED-OFF] Bug 10550 - Fix database typo wthdrawn This patch updates the wthdrawn field in items and deleteditems to be withdrawn instead. No functional changes are made. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Save for translation files (that will be fixed on next release), only occurrence of wthdrawn is on updatedatabase.pl No koha-qa errors. This touch many files, and I did not test everything, but all seems normal. I think that any problem could be fixed later. Perhaps both entries in updatedatabase.pl could be joined into one, but thats for QA.
QA comment: All looks good. Note that 1 authorized value named "WTHDRAWN" still exists. Marked as Passed QA.
Created attachment 20457 [details] [review] Bug 10550 - Fix database typo wthdrawn This patch updates the wthdrawn field in items and deleteditems to be withdrawn instead. No functional changes are made. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Save for translation files (that will be fixed on next release), only occurrence of wthdrawn is on updatedatabase.pl No koha-qa errors. This touch many files, and I did not test everything, but all seems normal. I think that any problem could be fixed later. Perhaps both entries in updatedatabase.pl could be joined into one, but thats for QA. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 20458 [details] [review] Bug 10550: Merge 2 updatedatabase entries into 1 Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Pushed to master, along with a couple follow-ups. Thanks, Kyle!
Added to qa tools: commit c90d0c5e5436daec23d2c6e21e5759e8344ad1f5 Author: Jonathan Druart <jonathan.druart@biblibre.com> AuthorDate: Mon Sep 9 09:45:10 2013 +0200 wthdrawn is a typo (see bug 10550).
Thx Jonathan!
Just to note that the MARC frameworks on the wiki ( http://wiki.koha-community.org/wiki/MARC_frameworks ) weren't updated with this bug. It's now done.
Thx Nicholas!