Summary: | Untranslatable strings in additem.js | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | I18N/L10N | Assignee: | Bugs List <koha-bugs> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | normal | ||
Priority: | P5 - low | CC: | bgkriegel, f.demians, gmcharlt, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 10514 | ||
Bug Blocks: | |||
Attachments: |
Bug 10576 - Untranslatable strings in additem.js
Bug 10576 - Untranslatable strings in additem.js [PASSED QA] Bug 10576 - Untranslatable strings in additem.js |
Description
Owen Leonard
2013-07-11 14:44:11 UTC
Created attachment 19796 [details] [review] Bug 10576 - Untranslatable strings in additem.js There are a couple of untranslatable strings in additem.js. This patch moves the strings out of the script and into the include file which has been created for this purpose. To test, apply the patch and test the process for adding an item to an existing or new basket (with AcqCreateItem set to "when placing an order." The add item form should be correctly labeled "Add item." After adding an item, click to edit it again. The form should now be labeled "Update item." Created attachment 19818 [details] [review] Bug 10576 - Untranslatable strings in additem.js There are a couple of untranslatable strings in additem.js. This patch moves the strings out of the script and into the include file which has been created for this purpose. To test, apply the patch and test the process for adding an item to an existing or new basket (with AcqCreateItem set to "when placing an order." The add item form should be correctly labeled "Add item." After adding an item, click to edit it again. The form should now be labeled "Update item." Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Created attachment 19829 [details] [review] [PASSED QA] Bug 10576 - Untranslatable strings in additem.js There are a couple of untranslatable strings in additem.js. This patch moves the strings out of the script and into the include file which has been created for this purpose. To test, apply the patch and test the process for adding an item to an existing or new basket (with AcqCreateItem set to "when placing an order." The add item form should be correctly labeled "Add item." After adding an item, click to edit it again. The form should now be labeled "Update item." Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works nicely and passes all tests. Made sure strings can be translated testing with German templates. Pushed to master. Thanks, Owen! This patch has been pushed to 3.12.x, will be in 3.12.4. Thanks Owen! Pushed to 3.10.x, will be in 3.10.11 |