Bug 10586

Summary: Printing cart from Firefox seems to be missing CSS
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: OPACAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P5 - low CC: gmcharlt, tomascohen
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 10586 - Printing cart from Firefox seems to be missing CSS
Bug 10586 - Printing cart from Firefox seems to be missing CSS
Bug 10586 - Printing cart from Firefox seems to be missing CSS

Description Katrin Fischer 2013-07-14 11:31:40 UTC
To test:
- Print a cart from Firefox
- Print a cart from Chromium

In my tests Chromium printed the table borders nicely formated using a non-serif font for the text, while Firefox printed using a serif font and the table without border lines.
Comment 1 Owen Leonard 2013-07-19 16:28:10 UTC Comment hidden (obsolete)
Comment 2 Liz Rea 2013-07-19 22:09:36 UTC Comment hidden (obsolete)
Comment 3 Chris Cormack 2013-07-20 21:30:21 UTC
Created attachment 19822 [details] [review]
Bug 10586 - Printing cart from Firefox seems to be missing CSS

When printing the Cart from Firefox the styling is off even though it
looks correct in preview. I think this may be because the preview is
including stylesheets designated for screen.

This patch removes special handling of JS and CSS assets for the Cart's
print view, letting the page handle print styling like other pages in
the OPAC.

To test, put items in your Cart in the OPAC. Open your Cart and click
the "print" link. Your printout should be correctly styled and match the
preview.

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Tested both fail condition and condition with patch - display is much improved. Thanks, Owen!

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Works as advertised
Comment 4 Galen Charlton 2013-07-22 16:13:57 UTC
Pushed to master.  Thanks, Owen!
Comment 5 Tomás Cohen Arazi (tcohen) 2013-08-16 13:25:32 UTC
This patch has been pushed to 3.12.x, will be in 3.12.4.

Thanks Owen!