| Summary: | DelBookseller's return value needs to be more explicit in C4::Bookseller.pm | ||
|---|---|---|---|
| Product: | Koha | Reporter: | kenza <kenza.zaki> |
| Component: | Acquisitions | Assignee: | kenza <kenza.zaki> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | gmcharlt, kenza.zaki |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 10528 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 10630: DelBookseller's always returns undef in C4::Bookseller.pm
Bug 10630: DelBookseller's always returns undef in C4::Bookseller.pm Bug 10630: DelBookseller's always returns undef in C4::Bookseller.pm [PASSED QA] Bug 10630: DelBookseller's always returns undef in C4::Bookseller.pm |
||
|
Description
kenza
2013-07-23 15:05:03 UTC
Created attachment 19927 [details] [review] Bug 10630: DelBookseller's always returns undef in C4::Bookseller.pm This patch makes DelBookseller returns the number of supplier it has deleted or undef if nothing has been deleted. It also adds some regression tests. To test: prove t/db_dependent/Bookseller.t t/db_dependent/Bookseller.t .. ok All tests successful. Files=1, Tests=7, 0 wallclock secs ( 0.02 usr 0.00 sys + 0.40 cusr 0.03 csys = 0.45 CPU) Result: PASS Created attachment 19937 [details] [review] Bug 10630: DelBookseller's always returns undef in C4::Bookseller.pm This patch makes DelBookseller returns the number of supplier it has deleted or undef if nothing has been deleted. It also fixes a test which doesn't pass before in t/db_dependent/Bookseller.t To test: prove t/db_dependent/Bookseller.t t/db_dependent/Bookseller.t .. 1/54 All tests successful. Files=1, Tests=54, 1 wallclock secs ( 0.02 usr 0.00 sys + 0.48 cusr 0.02 csys = 0.52 CPU) Result: PASS Created attachment 20203 [details] [review] Bug 10630: DelBookseller's always returns undef in C4::Bookseller.pm This patch makes DelBookseller returns the number of supplier it has deleted or undef if nothing has been deleted. It also fixes a test which doesn't pass before in t/db_dependent/Bookseller.t To test: prove t/db_dependent/Bookseller.t t/db_dependent/Bookseller.t .. 1/54 All tests successful. Files=1, Tests=54, 1 wallclock secs ( 0.02 usr 0.00 sys + 0.48 cusr 0.02 csys = 0.52 CPU) Result: PASS Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Created attachment 20586 [details] [review] [PASSED QA] Bug 10630: DelBookseller's always returns undef in C4::Bookseller.pm This patch makes DelBookseller returns the number of supplier it has deleted or undef if nothing has been deleted. It also fixes a test which doesn't pass before in t/db_dependent/Bookseller.t To test: prove t/db_dependent/Bookseller.t t/db_dependent/Bookseller.t .. 1/54 All tests successful. Files=1, Tests=54, 1 wallclock secs ( 0.02 usr 0.00 sys + 0.48 cusr 0.02 csys = 0.52 CPU) Result: PASS Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Logical change and makes another test pass. Tested with patch for 10528 applied. Pushed to master. Thanks, Kenza! |