Bug 10630 - DelBookseller's return value needs to be more explicit in C4::Bookseller.pm
Summary: DelBookseller's return value needs to be more explicit in C4::Bookseller.pm
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal
Assignee: kenza
QA Contact: Testopia
URL:
Keywords:
Depends on: 10528
Blocks:
  Show dependency tree / graph
 
Reported: 2013-07-23 15:05 UTC by kenza
Modified: 2014-12-07 20:02 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 10630: DelBookseller's always returns undef in C4::Bookseller.pm (4.58 KB, patch)
2013-07-24 13:42 UTC, kenza 		Details | Diff | Splinter Review
Bug 10630: DelBookseller's always returns undef in C4::Bookseller.pm (1.94 KB, patch)
2013-07-25 07:43 UTC, kenza 		Details | Diff | Splinter Review
Bug 10630: DelBookseller's always returns undef in C4::Bookseller.pm (1.99 KB, patch)
2013-08-08 23:27 UTC, Chris Cormack 		Details | Diff | Splinter Review
[PASSED QA] Bug 10630: DelBookseller's always returns undef in C4::Bookseller.pm (2.11 KB, patch)
2013-08-25 11:59 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description kenza 2013-07-23 15:05:03 UTC 
DelBookSeller always returns undef, even if nothing has been deleted.
Comment 1 kenza 2013-07-24 13:42:40 UTC Comment hidden (obsolete)
Comment 2 kenza 2013-07-25 07:43:49 UTC Comment hidden (obsolete)
Comment 3 Chris Cormack 2013-08-08 23:27:28 UTC Comment hidden (obsolete)
Comment 4 Katrin Fischer 2013-08-25 11:59:02 UTC 
Created attachment 20586 [details] [review]
[PASSED QA] Bug 10630: DelBookseller's always returns undef in C4::Bookseller.pm

This patch makes DelBookseller returns the number of supplier it has deleted
or undef if nothing has been deleted.
It also fixes a test which doesn't pass before in t/db_dependent/Bookseller.t

To test:
prove t/db_dependent/Bookseller.t
t/db_dependent/Bookseller.t .. 1/54
All tests successful.
Files=1, Tests=54,  1 wallclock secs ( 0.02 usr  0.00 sys +  0.48 cusr  0.02 csys =  0.52 CPU)
Result: PASS

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Logical change and makes another test pass.
Comment 5 Katrin Fischer 2013-08-25 11:59:24 UTC 
Tested with patch for 10528 applied.
Comment 6 Galen Charlton 2013-09-08 20:34:09 UTC 
Pushed to master.  Thanks, Kenza!