| Summary: | Remove C4::ILSDI::Utility | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Srdjan Jankovic <srdjan> |
| Component: | OPAC | Assignee: | Srdjan Jankovic <srdjan> |
| Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | fridolin.somers, gitbot, gmcharlt, m.de.rooy |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Crowdfunding goal: | 0 |
| Patch complexity: | Trivial patch | Documentation contact: | |
| Documentation submission: | Text to go in the release notes: | ||
| Version(s) released in: | Circulation function: | ||
| Attachments: |
bug_10781: Removed ILSDI::Utility
bug_10781: Removed ILSDI::Utility bug_10781: Removed ILSDI::Utility bug_10781: Removed ILSDI::Utility |
||
|
Description
Srdjan Jankovic
2013-08-26 00:09:23 UTC
Created attachment 20620 [details] [review] bug_10781: Removed ILSDI::Utility Test: This should be a noop. Regression testing required: /cgi-bin/koha/ilsdi.pl functioanality, in particuler: GetAvailability - ?service=Describe&verb=GetAvailability AuthenticatePatron - ?service=Describe&verb=AuthenticatePatron ILS-DI syspref must be turned on Applying: bug_10781: Removed ILSDI::Utility
/usr/share/koha/testclone/.git/rebase-apply/patch:43: tab in indent.
my ($biblionumber, $status, $msg, $location) = _availability($id);
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
<stdin>:43: tab in indent.
my ($biblionumber, $status, $msg, $location) = _availability($id);
warning: 1 line applied after fixing whitespace errors.
Falling back to patching base and 3-way merge...
Removing t/ILSDI_Utility.t
CONFLICT (modify/delete): C4/ILSDI/Utility.pm deleted in bug_10781: Removed ILSDI::Utility and modified in HEAD. Version HEAD of C4/ILSDI/Utility.pm left in tree.
Auto-merging C4/ILSDI/Services.pm
CONFLICT (content): Merge conflict in C4/ILSDI/Services.pm
Failed to merge in the changes.
Created attachment 21688 [details] [review] bug_10781: Removed ILSDI::Utility Test: This should be a noop. Regression testing required: /cgi-bin/koha/ilsdi.pl functioanality, in particuler: GetAvailability - ?service=Describe&verb=GetAvailability AuthenticatePatron - ?service=Describe&verb=AuthenticatePatron ILS-DI syspref must be turned on Patch applied cleanly, go forth and signoff Created attachment 22402 [details] [review] bug_10781: Removed ILSDI::Utility Test: This should be a noop. Regression testing required: /cgi-bin/koha/ilsdi.pl functioanality, in particuler: GetAvailability - ?service=Describe&verb=GetAvailability AuthenticatePatron - ?service=Describe&verb=AuthenticatePatron ILS-DI syspref must be turned on Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 22725 [details] [review] bug_10781: Removed ILSDI::Utility Test: This should be a noop. Regression testing required: /cgi-bin/koha/ilsdi.pl functioanality, in particuler: GetAvailability - ?service=Describe&verb=GetAvailability AuthenticatePatron - ?service=Describe&verb=AuthenticatePatron ILS-DI syspref must be turned on Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> QA Comment: Tested both functions with ilsdi.pl. Works fine. Code looks good to me. No complaints from qa tools. Moving from enh to bugfix. No string changes. Still looks like a candidate for 3.14. Passed QA Pushed to master. Thanks, Srdjan! Patch pushed to 3.14.x, will be in 3.14.2 |