Summary: | adding/editing item types screen mis aligned if noItemTypeImages not showing | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
Component: | Templates | Assignee: | Bernardo Gonzalez Kriegel <bgkriegel> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | bgkriegel, fridolin.somers, gmcharlt |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
add item type
Bug 10790 - adding/editing item types screen mis aligned if noItemTypeImages not showing [SIGNED OFF] Bug 10790 - adding/editing item types screen mis aligned if noItemTypeImages not showing Bug 10790 - adding/editing item types screen mis aligned if noItemTypeImages not showing |
Created attachment 26467 [details] [review] Bug 10790 - adding/editing item types screen mis aligned if noItemTypeImages not showing This patch fixes the odd behavior when noItemTypesImages is set to 'Don't show'. Just a misplaced </div> To test: 1) Set syspref noItemTypeImages to 'Don't show' 2) Go to Admininstration > Item types 3) Edit some item type, you will view a display similar to the attached image 4) Apply the patch 5) Reload the page, now the display is fixed 6) Change syspref to 'Show' to check that the display is also good Also fixed a missing '/' on a closing select *** Bug 11424 has been marked as a duplicate of this bug. *** Created attachment 26480 [details] [review] [SIGNED OFF] Bug 10790 - adding/editing item types screen mis aligned if noItemTypeImages not showing This patch fixes the odd behavior when noItemTypesImages is set to 'Don't show'. Just a misplaced </div> To test: 1) Set syspref noItemTypeImages to 'Don't show' 2) Go to Admininstration > Item types 3) Edit some item type, you will view a display similar to the attached image 4) Apply the patch 5) Reload the page, now the display is fixed 6) Change syspref to 'Show' to check that the display is also good Also fixed a missing '/' on a closing select Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Created attachment 26483 [details] [review] Bug 10790 - adding/editing item types screen mis aligned if noItemTypeImages not showing This patch fixes the odd behavior when noItemTypesImages is set to 'Don't show'. Just a misplaced </div> To test: 1) Set syspref noItemTypeImages to 'Don't show' 2) Go to Admininstration > Item types 3) Edit some item type, you will view a display similar to the attached image 4) Apply the patch 5) Reload the page, now the display is fixed 6) Change syspref to 'Show' to check that the display is also good Also fixed a missing '/' on a closing select Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Pushed to master. Thanks, Bernardo! Pushed to 3.14.x, will be in 3.14.08 |
Created attachment 20661 [details] add item type See attached. When you have noItemTypeImages set to "Don't show" everything goes wonky on the add item type screen.