Summary: | Silence warnings in members/member.pl | ||
---|---|---|---|
Product: | Koha | Reporter: | Chris Cormack <chris> |
Component: | Patrons | Assignee: | Chris Cormack <chris> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | gmcharlt, kyle.m.hall |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Small patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | 10835 | ||
Bug Blocks: | |||
Attachments: |
Bug 10838 : Silence warns in members/member.pl
[SIGNED-OFF] Bug 10838 : Silence warns in members/member.pl [PASSED QA] Bug 10838 : Silence warns in members/member.pl |
Description
Chris Cormack
2013-09-07 03:22:08 UTC
Created attachment 20841 [details] [review] Bug 10838 : Silence warns in members/member.pl To test 1/ Uncomment the use warnings line 2/ Search for a patron, notice all the warnings 3/ Browse for a patron, notice warnings 4/ Apply patch 5/ Repeat 3 and 4 6/ Notice no errors and the search still works This depends on the patch for Bug 10835 Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Created attachment 20912 [details] [review] [SIGNED-OFF] Bug 10838 : Silence warns in members/member.pl To test 1/ Uncomment the use warnings line 2/ Search for a patron, notice all the warnings 3/ Browse for a patron, notice warnings 4/ Apply patch 5/ Repeat 3 and 4 6/ Notice no errors and the search still works This depends on the patch for Bug 10835 Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 20974 [details] [review] [PASSED QA] Bug 10838 : Silence warns in members/member.pl To test 1/ Uncomment the use warnings line 2/ Search for a patron, notice all the warnings 3/ Browse for a patron, notice warnings 4/ Apply patch 5/ Repeat 3 and 4 6/ Notice no errors and the search still works This depends on the patch for Bug 10835 Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests, no regressions found. Pushed to master, along with a follow-up that silences another warning. Thanks, Chris! |