Bug 10835 - Patron search for using "contains" search type fails with only one search term
Summary: Patron search for using "contains" search type fails with only one search term
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Kyle M Hall
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 8845
Blocks: 10838
  Show dependency treegraph
 
Reported: 2013-09-06 17:10 UTC by Kyle M Hall
Modified: 2014-12-07 20:02 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 10835 - Patron search for using "contains" search type fails with only one search term (1.45 KB, patch)
2013-09-06 17:12 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 10835 - Patron search for using "contains" search type fails with only one search term (1.45 KB, patch)
2013-09-06 17:13 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 10835 - Patron search for using "contains" search type fails with only one search term (1.50 KB, patch)
2013-09-07 03:19 UTC, Chris Cormack
Details | Diff | Splinter Review
[PASSED QA] Bug 10835 - Patron search for using "contains" search type fails with only one search term (1.74 KB, patch)
2013-09-07 18:16 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2013-09-06 17:10:06 UTC
The patron search type option "contains" works fine for multiple strings, but returns no results for a single string search. For example, the patron "Henry Acevedo" will be returned for a "contains" search "en ev" but not for just "en" or "ev".
Comment 1 Kyle M Hall 2013-09-06 17:12:44 UTC Comment hidden (obsolete)
Comment 2 Kyle M Hall 2013-09-06 17:13:59 UTC Comment hidden (obsolete)
Comment 3 Chris Cormack 2013-09-07 03:19:47 UTC Comment hidden (obsolete)
Comment 4 Katrin Fischer 2013-09-07 18:16:00 UTC
Created attachment 20854 [details] [review]
[PASSED QA] Bug 10835 - Patron search for using "contains" search type fails with only one search term

The patron search type option "contains" works fine for multiple
strings, but returns no results for a single string search. For example,
the patron "Henry Acevedo" will be returned for a "contains" search
"en ev" but not for just "en" or "ev".

Test Plan:
1) Create 2 patrons named "Test One" and "Test Two"
2) Run a "contains" search for the term "est"
3) Note no results were found
4) Apply this patch
5) Repeat step 2
6) Note the patrons now display in the search results.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
All tests and QA script pass.
Also checked that 'starts with' still works as expected -
searching for ev will only return "Eva Dillon" from the
example patrons in this case.
Comment 5 Galen Charlton 2013-09-07 20:53:37 UTC
Pushed to master.  Thanks, Kyle!