|
Description
Cecil Hillyard
2013-09-17 20:38:02 UTC
I want to add to this that the problem is also a language issue - the text says "Add new bibliographic records into this framework" but the records in question aren't 'new' so that's where part of the confusion occurs This is still broken in current master (but only when records are being matched & replaced when importing; for the records imported 'as new', framework choosen by the user seems to be saved and retained properly - ?).
Looks like some changes introduced by commit 82dc7b55a8b5a7642a906dcd8963952b7464adb1 ("Bug 4321: clean C4::Biblio::GetBiblio and uses") got inadvertantly reverted by next commmit (6e71b80ca39e6f1d2c31659a9a656de807ef3f32, "Bug 7475: Teach matching rules to handle authorities").
Another remaining place where GetBiblio() return results are wrongly assigned is serials/subscription-history.pl script.
Created attachment 37126 [details] [review] Bug 10906 - Reimported records into Koha are imported only as DEFAULT frameworks, not what they were originally Existing framework code is currently not retained when local record gets replaced during batch import, or when the restore/reverse function is being used. This patch fixes aforementioned issues by correcting outdated GetBiblio() calls in C4/ImportBatch.pm To test: 1/ try to replicate the issue: import some MARC records with "Tools -> Stage MARC records for import" etc., using test setup, matching rules and so on such that some existing records will get replaced with imported ones 2/ observe that records replaced during import now open in the editor with 'Default' framework, even if they have some other framework set up previously 3/ apply patch 4/ redo 1/, confirming that this problem is no longer replicable 5/ try use 'restore' function with some freshly imported records, ensure that original framework code got retained in the records which had their imports reverted Created attachment 37442 [details] [review] Bug 10906 - Reimported records into Koha are imported only as DEFAULT frameworks, not what they were originally Existing framework code is currently not retained when local record gets replaced during batch import, or when the restore/reverse function is being used. This patch fixes aforementioned issues by correcting outdated GetBiblio() calls in C4/ImportBatch.pm To test: 1/ try to replicate the issue: import some MARC records with "Tools -> Stage MARC records for import" etc., using test setup, matching rules and so on such that some existing records will get replaced with imported ones 2/ observe that records replaced during import now open in the editor with 'Default' framework, even if they have some other framework set up previously 3/ apply patch 4/ redo 1/, confirming that this problem is no longer replicable 5/ try use 'restore' function with some freshly imported records, ensure that original framework code got retained in the records which had their imports reverted NOTE: I confirmed this change by 1) git grep "=\s*GetBiblio\s*(" -- this shows how GetBiblio is called elsewhere. It differed! So then... 2) vi C4/Biblio.pm /sub GetBiblio -- find the right one, notice it only returns a HASH ref, not an array. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Created attachment 37456 [details] [review] [PASSED QA] Bug 10906 - Reimported records into Koha are imported only as DEFAULT frameworks, not what they were originally Existing framework code is currently not retained when local record gets replaced during batch import, or when the restore/reverse function is being used. This patch fixes aforementioned issues by correcting outdated GetBiblio() calls in C4/ImportBatch.pm To test: 1/ try to replicate the issue: import some MARC records with "Tools -> Stage MARC records for import" etc., using test setup, matching rules and so on such that some existing records will get replaced with imported ones 2/ observe that records replaced during import now open in the editor with 'Default' framework, even if they have some other framework set up previously 3/ apply patch 4/ redo 1/, confirming that this problem is no longer replicable 5/ try use 'restore' function with some freshly imported records, ensure that original framework code got retained in the records which had their imports reverted NOTE: I confirmed this change by 1) git grep "=\s*GetBiblio\s*(" -- this shows how GetBiblio is called elsewhere. It differed! So then... 2) vi C4/Biblio.pm /sub GetBiblio -- find the right one, notice it only returns a HASH ref, not an array. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Patch pushed to master. Thanks Jacek! Pushed to 3.18.x will be in 3.18.6 |