| Summary: | Records with 880 fields have broken details links in intranet search results using XSLT. | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Kyle M Hall (khall) <kyle> |
| Component: | Staff interface | Assignee: | Kyle M Hall (khall) <kyle> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | bgkriegel, gmcharlt, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4285 | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 10911 - Records with 880 fields have broken details links in intranet search results using XSLT.
Example record with 880 fields [SIGNED-OFF] Bug 10911 - Records with 880 fields have broken details links in intranet search results using XSLT. [PASSED QA] Bug 10911 - Records with 880 fields have broken details links in intranet search results using XSLT. |
||
|
Description
Kyle M Hall (khall)
2013-09-18 19:23:35 UTC
Created attachment 21213 [details] [review] Bug 10911 - Records with 880 fields have broken details links in intranet search results using XSLT. Koha intranet search results using XSLT for records with 880 fields have the details link created by a code path that incorrectly links to some opac pages. Test Plan: 1) Enable XSLT for intranet search results 2) Upload or create a record with at least one 880 field 3) Search for the item ( must have multiple hits to avoid redirection ) 4) Click the title link, note it is broken 5) Apply this patch 6) Click the title link, note it is correct Created attachment 21214 [details]
Example record with 880 fields
Created attachment 21305 [details] [review] [SIGNED-OFF] Bug 10911 - Records with 880 fields have broken details links in intranet search results using XSLT. Koha intranet search results using XSLT for records with 880 fields have the details link created by a code path that incorrectly links to some opac pages. Test Plan: 1) Enable XSLT for intranet search results 2) Upload or create a record with at least one 880 field 3) Search for the item ( must have multiple hits to avoid redirection ) 4) Click the title link, note it is broken 5) Apply this patch 6) Click the title link, note it is correct Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described, no koha-qa errors. Test 1) imported two times sample record 2) reindex 3) search, find example record, broken links 4) applied patch 5) refresh, good links NOTE: A similar (invalid references) problem is present on UNIMARC and NORMAC files I'll file a new bug for those cases. Created attachment 21308 [details] [review] [PASSED QA] Bug 10911 - Records with 880 fields have broken details links in intranet search results using XSLT. Koha intranet search results using XSLT for records with 880 fields have the details link created by a code path that incorrectly links to some opac pages. Test Plan: 1) Enable XSLT for intranet search results 2) Upload or create a record with at least one 880 field 3) Search for the item ( must have multiple hits to avoid redirection ) 4) Click the title link, note it is broken 5) Apply this patch 6) Click the title link, note it is correct Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described, no koha-qa errors. Test 1) imported two times sample record 2) reindex 3) search, find example record, broken links 4) applied patch 5) refresh, good links NOTE: A similar (invalid references) problem is present on UNIMARC and NORMAC files I'll file a new bug for those cases. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works nicely, tested with a different set of sample records with Hebrew 880 fields. Pushed to master. Thanks, Kyle! This patch has been pushed to 3.12.x, will be in 3.12.7. Thanks Kyle! |