| Summary: | Sample itemtypes can't load on new install | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Bernardo Gonzalez Kriegel <bgkriegel> |
| Component: | Installation and upgrade (web-based installer) | Assignee: | Bernardo Gonzalez Kriegel <bgkriegel> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | gitbot, gmcharlt, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10969 | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 10513 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 10965 - Sample itemtypes can't load on new install
Bug 10965 - Sample itemtypes can't load on new install [PASSED QA] Bug 10965 - Sample itemtypes can't load on new install |
||
|
Description
Bernardo Gonzalez Kriegel
2013-09-28 19:44:01 UTC
Created attachment 21551 [details] [review] Bug 10965 - Sample itemtypes can't load on new install Bug 10513 added two columns to table itemtypes, but sample_itemtypes can't be loaded because it relies on old structure. This patch rewrites sample_itemtypes.sql, stating explicitly columns, removing backticks and consolidates all in one insertion. To test: 1) On master with current DB structure, delete item types 2) try loading sample_itemtyes.sql It fails with "ERROR 1136 (21S01) at line 1: Column count doesn't match value count at row 1" 3) apply patch 4) try again, this time it will load and itemtypes created Patch applied cleanly, go forth and signoff Created attachment 21567 [details] [review] Bug 10965 - Sample itemtypes can't load on new install Bug 10513 added two columns to table itemtypes, but sample_itemtypes can't be loaded because it relies on old structure. This patch rewrites sample_itemtypes.sql, stating explicitly columns, removing backticks and consolidates all in one insertion. To test: 1) On master with current DB structure, delete item types 2) try loading sample_itemtyes.sql It fails with "ERROR 1136 (21S01) at line 1: Column count doesn't match value count at row 1" 3) apply patch 4) try again, this time it will load and itemtypes created Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> I think we need follow-ups to fix the translated installers as well. Created attachment 21597 [details] [review] [PASSED QA] Bug 10965 - Sample itemtypes can't load on new install Bug 10513 added two columns to table itemtypes, but sample_itemtypes can't be loaded because it relies on old structure. This patch rewrites sample_itemtypes.sql, stating explicitly columns, removing backticks and consolidates all in one insertion. To test: 1) On master with current DB structure, delete item types 2) try loading sample_itemtyes.sql It fails with "ERROR 1136 (21S01) at line 1: Column count doesn't match value count at row 1" 3) apply patch 4) try again, this time it will load and itemtypes created Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> SQL change only. Tested by running the web installer on an empty database. All sample data loads without errors. Working on a follow-up for translated installers. (In reply to Katrin Fischer from comment #6) > Working on a follow-up for translated installers. If you like I can do this. Somehow I forget other languages :) Pushed to master. Thanks, Bernardo! |