| Summary: | Unimarc: Authority summary does not work as expected | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Cataloging | Assignee: | Julian Maurice <julian.maurice> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | chris, f.demians, gitbot, gmcharlt, julian.maurice, m.de.rooy, mathsabypro, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 10985: [UNIMARC] Fix authority summary
Bug 10985: [UNIMARC] Fix authority summary [SIGNED-OFF] Bug 10985: [UNIMARC] Fix authority summary [PASSED QA] Bug 10985: [UNIMARC] Fix authority summary |
||
|
Description
Jonathan Druart
2013-10-02 12:20:14 UTC
Created attachment 21714 [details] [review] Bug 10985: [UNIMARC] Fix authority summary Test plan: - edit an authority summary with: NP : [200a][, 200b][ 200d][-- 152b --][ ; 200c][ (200f)] [001*] [ppn: 009*] - create a new authority with previous fields (it is possible some fields don't exist). - search this authority and verify the summary is someting like: NP : Name, D.-- NP -- 23849 ppn my_ppn: - Verify some summary for existing authority and check there are correct. /!\ For the ppn, it should be defined in the zebra indexes. Patch applied cleanly, go forth and signoff Patch applied cleanly, go forth and signoff I put [200a][, 200b][ 200d][-- 152b --][ ; 200c][ (200f)] [001*] [ppn: 009*] in Authority types for "NP" without your patch, a search on authorities NP gives : 1483 -- Aimée, Anouk -- -- NP -- : 1153 -- -- NP -- -- Aitchison, Jean (1925-....) : 1392 -- -- NP -- -- Alcalá-Zamora y Torres, Niceto (1877-1949) : 1579 -- Abraham, Daniel -- -- NP -- : 1011 -- -- NP -- -- 余, 华 (1960-....) -- Yu, Hua (1960-....) : So, it is broken. with your patch, it gives: Aimée, Anouk-- NP -- 1483 : Aitchison, Jean-- NP -- (1925-....) 1153 ppn: 031562558: Alcalá-Zamora y Torres, Niceto-- NP -- (1877-1949) 1392 ppn: 031603718: Abraham, Daniel-- NP -- 1579 : 余, 华-- NP -- (1960-....) 1011 ppn: 033893438: 余 华 1960-.... Yu Hua 1960-.... So, it works ;-) But I have a question for the last case. It is a record with two 200 fields, in chinese and in french. Is it normal to only have the chinese name on the first line (the line defined by "[200a][, 200b][ 200d][-- 152b --][ ; 200c][ (200f)] [001*] [ppn: 009*]") ? If it is normal, I will sign off. Mathieu (In reply to mathieu saby from comment #4) > But I have a question for the last case. It is a record with two 200 fields, > in chinese and in french. Is it normal to only have the chinese name on the > first line (the line defined by "[200a][, 200b][ 200d][-- 152b --][ ; 200c][ > (200f)] [001*] [ppn: 009*]") ? Yes, this patch only processes the first field. Created attachment 36809 [details] [review] Bug 10985: [UNIMARC] Fix authority summary The problem is the template in authority type summary is not respected at all. It is only read to see which fields and subfields should appear in the summary. This patch fixes that. It also fixes a bug in auth_finder.pl plugin when summary contains fields other than 2XX. Test plan: 0/ You must use a UNIMARC setup for those tests 1/ edit an authority type summary with: NP : [200a][, 200b][ 200d][-- 152b --][ ; 200c][ (200f)] [001*] [ppn: 009*] 2/ create a new authority with previous fields (it is possible some fields don't exist). 3/ search this authority and verify the summary is someting like: NP : Name, D.-- NP -- 23849 ppn: my_ppn 4/ Verify some summary for existing authorities and check they are correct. 5/ Edit a biblio record and use the plugin auth_finder.pl (for example in a 7XX field) 6/ Do a search and verify the summary is correct 7/ Click on 'choose' or one of the numbered links ('1', '2', ... ; you should have multiple 2XX fields for the numbered links to show up) 8/ Verify that the biblio field is correctly filled. /!\ For the ppn, it should be defined in the zebra indexes. In MARC21 and NORMARC setups, this patch should change nothing, please verify that too (you can check that the auth_finder.pl plugin is still working and the auth type summary is correctly displayed in authorities search and auth_finder.pl plugin). Patch rebased, test plan improved, and additional fix added Created attachment 37599 [details] [review] [SIGNED-OFF] Bug 10985: [UNIMARC] Fix authority summary The problem is the template in authority type summary is not respected at all. It is only read to see which fields and subfields should appear in the summary. This patch fixes that. It also fixes a bug in auth_finder.pl plugin when summary contains fields other than 2XX. Test plan: 0/ You must use a UNIMARC setup for those tests 1/ edit an authority type summary with: NP : [200a][, 200b][ 200d][-- 152b --][ ; 200c][ (200f)] [001*] [ppn: 009*] 2/ create a new authority with previous fields (it is possible some fields don't exist). 3/ search this authority and verify the summary is someting like: NP : Name, D.-- NP -- 23849 ppn: my_ppn 4/ Verify some summary for existing authorities and check they are correct. 5/ Edit a biblio record and use the plugin auth_finder.pl (for example in a 7XX field) 6/ Do a search and verify the summary is correct 7/ Click on 'choose' or one of the numbered links ('1', '2', ... ; you should have multiple 2XX fields for the numbered links to show up) 8/ Verify that the biblio field is correctly filled. /!\ For the ppn, it should be defined in the zebra indexes. In MARC21 and NORMARC setups, this patch should change nothing, please verify that too (you can check that the auth_finder.pl plugin is still working and the auth type summary is correctly displayed in authorities search and auth_finder.pl plugin). Signed-off-by: Frederic Demians <f.demians@tamil.fr> It works as described, both in authority search result page, and in authority data entry plugin. Created attachment 38293 [details] [review] [PASSED QA] Bug 10985: [UNIMARC] Fix authority summary The problem is the template in authority type summary is not respected at all. It is only read to see which fields and subfields should appear in the summary. This patch fixes that. It also fixes a bug in auth_finder.pl plugin when summary contains fields other than 2XX. Test plan: 0/ You must use a UNIMARC setup for those tests 1/ edit an authority type summary with: NP : [200a][, 200b][ 200d][-- 152b --][ ; 200c][ (200f)] [001*] [ppn: 009*] 2/ create a new authority with previous fields (it is possible some fields don't exist). 3/ search this authority and verify the summary is someting like: NP : Name, D.-- NP -- 23849 ppn: my_ppn 4/ Verify some summary for existing authorities and check they are correct. 5/ Edit a biblio record and use the plugin auth_finder.pl (for example in a 7XX field) 6/ Do a search and verify the summary is correct 7/ Click on 'choose' or one of the numbered links ('1', '2', ... ; you should have multiple 2XX fields for the numbered links to show up) 8/ Verify that the biblio field is correctly filled. /!\ For the ppn, it should be defined in the zebra indexes. In MARC21 and NORMARC setups, this patch should change nothing, please verify that too (you can check that the auth_finder.pl plugin is still working and the auth type summary is correctly displayed in authorities search and auth_finder.pl plugin). Signed-off-by: Frederic Demians <f.demians@tamil.fr> It works as described, both in authority search result page, and in authority data entry plugin. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Patch pushed to master. Thanks Jonathan! Pushed to 3.18.x will be in 3.18.7 |