Description
Tomás Cohen Arazi (tcohen)
2013-10-02 18:51:41 UTC
Created attachment 21733 [details] [review] Bug 10987: Too many 'see also' and 'see from' labels occurences If an authority record has more than one 4xx$a (or 5xx$a) entries the corresponding labels 'see also' and 'used for/see from' are repeated. To test: - Have authority records with more than one entry on the 4xx (or 5xx) fields. - Do a search, check "see also:" (or 'used for/see from') appear more than once. - Apply the patch - Reload and check it looks nicer :-D - Repeat for: staff auth search, opac using ccsr, opac using prog - Signoff Regards To+ Sponsored-by: Universidad Nacional de Cordoba Patch applied cleanly, go forth and signoff Created attachment 21897 [details] [review] [SIGNED-OFF] Bug 10987: Too many 'see also' and 'see from' labels occurences If an authority record has more than one 4xx$a (or 5xx$a) entries the corresponding labels 'see also' and 'used for/see from' are repeated. To test: - Have authority records with more than one entry on the 4xx (or 5xx) fields. - Do a search, check "see also:" (or 'used for/see from') appear more than once. - Apply the patch - Reload and check it looks nicer :-D - Repeat for: staff auth search, opac using ccsr, opac using prog - Signoff Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as decribed. No koha-qa errors Nice view on staff and both opac Tomás, the patch does not apply anymore, could you rebase it please? fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search-results.inc). I forgot the dependency! Sorry. Tested with bug 10691. Works great. Marked as Passed QA. Created attachment 22788 [details] [review] Bug 10987: Too many 'see also' and 'see from' labels occurences If an authority record has more than one 4xx$a (or 5xx$a) entries the corresponding labels 'see also' and 'used for/see from' are repeated. To test: - Have authority records with more than one entry on the 4xx (or 5xx) fields. - Do a search, check "see also:" (or 'used for/see from') appear more than once. - Apply the patch - Reload and check it looks nicer :-D - Repeat for: staff auth search, opac using ccsr, opac using prog - Signoff Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as decribed. No koha-qa errors Nice view on staff and both opac Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Created attachment 23399 [details] [review] Bug 10987: Too many 'see also' and 'see from' labels occurences (rebased+bootstrap) If an authority record has more than one 4xx$a (or 5xx$a) entries the corresponding labels 'see also' and 'used for/see from' are repeated. To test: - Have authority records with more than one entry on the 4xx (or 5xx) fields. - Do a search, check "see also:" (or 'used for/see from') appear more than once. - Apply the patch - Reload and check it looks nicer :-D - Repeat for: staff auth search, opac using ccsr, opac using prog - Signoff Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as decribed. No koha-qa errors Nice view on staff and both opac Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Tested on top of bug 10691. All works great. Maybe it would be better to split patches for the OPAC. Marked as Passed QA. Created attachment 24464 [details] [review] Bug 10987: Too many 'see also' and 'see from' labels occurences (rebased+bootstrap) If an authority record has more than one 4xx$a (or 5xx$a) entries the corresponding labels 'see also' and 'used for/see from' are repeated. To test: - Have authority records with more than one entry on the 4xx (or 5xx) fields. - Do a search, check "see also:" (or 'used for/see from') appear more than once. - Apply the patch - Reload and check it looks nicer :-D - Repeat for: staff auth search, opac using ccsr, opac using prog - Signoff Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as decribed. No koha-qa errors Nice view on staff and both opac Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Pushed to master, along with a follow-up that repairs breakage in the display of an authority record that has only one 4XX, or one 5XX. Thanks, Tomás! |