Summary: | Useless column cancelledby in aqorders table | ||
---|---|---|---|
Product: | Koha | Reporter: | Mathieu Saby <mathsabypro> |
Component: | Database | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | jonathan.druart, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11008 | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 11007: Drop column aqorders.cancelledby
Bug 11007: Drop column aqorders.cancelledby [SIGNED-OFF] Bug 11007: Drop column aqorders.cancelledby [PASSED QA] Bug 11007: Drop column aqorders.cancelledby |
Description
Mathieu Saby
2013-10-07 15:25:51 UTC
Created attachment 29821 [details] [review] Bug 11007: Drop column aqorders.cancelledby It seems that this column has never been used. Test plan: 1/ Execute the updatedatabase entry. 2/ git grep cancelledby should not return occurrence in the code (except in Koha/Schema/* 3/ prove t/db_dependent/Acquisition.t should return green. Created attachment 29823 [details] [review] Bug 11007: Drop column aqorders.cancelledby It seems that this column has never been used. Test plan: 1/ Execute the updatedatabase entry. 2/ git grep cancelledby should not return occurrence in the code (except in Koha/Schema/* 3/ prove t/db_dependent/Acquisition.t should return green. (In reply to Jonathan Druart from comment #2) > 3/ prove t/db_dependent/Acquisition.t should return green. Does that test return green for you in master? It doesn't for me. (In reply to Owen Leonard from comment #3) > (In reply to Jonathan Druart from comment #2) > > > 3/ prove t/db_dependent/Acquisition.t should return green. > > Does that test return green for you in master? It doesn't for me. Yes, what is the error you get? Created attachment 30958 [details] [review] [SIGNED-OFF] Bug 11007: Drop column aqorders.cancelledby It seems that this column has never been used. Test plan: 1/ Execute the updatedatabase entry. 2/ git grep cancelledby should not return occurrence in the code (except in Koha/Schema/* 3/ prove t/db_dependent/Acquisition.t should return green. Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Created attachment 31038 [details] [review] [PASSED QA] Bug 11007: Drop column aqorders.cancelledby It seems that this column has never been used. Test plan: 1/ Execute the updatedatabase entry. 2/ git grep cancelledby should not return occurrence in the code (except in Koha/Schema/* 3/ prove t/db_dependent/Acquisition.t should return green. Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> I couldn't find any trace of this column being used. Passes tests and QA script, updates all necessary files. Patch pushed to master. Thanks Jonathan! |