In Schemaspy, column supplierreference is reported as "not used? always NULL". "grep -r supplierreference *" give this result, so I suppose it is true : blib/INTRANET_CGI_DIR/installer/data/mysql/update22to30.pl: field => 'supplierreference', blib/INTRANET_CGI_DIR/installer/data/mysql/kohastructure.sql: `supplierreference` mediumtext, -- not used? always NULL blib/INTRANET_CGI_DIR/installer/data/Pg/kohastructure.sql:supplierreference text, installer/data/mysql/update22to30.pl: field => 'supplierreference', installer/data/mysql/kohastructure.sql: `supplierreference` mediumtext, -- not used? always NULL installer/data/Pg/kohastructure.sql:supplierreference text, t/db_dependent/Acquisition.t: supplierreference I propose the deletion of this column. M. Saby
Created attachment 29822 [details] [review] Bug 11008: Drop column aqorders.supplierreference It seems that this column has never been used. Test plan: 1/ Execute the updatedatabase entry. 2/ git grep supplierreference should not return occurrence in the code (except in Koha/Schema/* 3/ prove t/db_dependent/Acquisition.t should return green.
Created attachment 33987 [details] [review] [SIGNED-OFF] Bug 11008: Drop column aqorders.supplierreference It seems that this column has never been used. Test plan: 1/ Execute the updatedatabase entry. 2/ git grep supplierreference should not return occurrence in the code (except in Koha/Schema/* 3/ prove t/db_dependent/Acquisition.t should return green. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr>
Created attachment 33988 [details] [review] [SIGNED-OFF] Bug 11008: Drop column aqorders.supplierreference It seems that this column has never been used. Test plan: 1/ Execute the updatedatabase entry. 2/ git grep supplierreference should not return occurrence in the code (except in Koha/Schema/* 3/ prove t/db_dependent/Acquisition.t should return green. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr>
Created attachment 34161 [details] [review] [PASSED QA] Bug 11008: Drop column aqorders.supplierreference It seems that this column has never been used. Test plan: 1/ Execute the updatedatabase entry. 2/ git grep supplierreference should not return occurrence in the code (except in Koha/Schema/* 3/ prove t/db_dependent/Acquisition.t should return green. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 37738 [details] [review] Bug 11008: (RM followup) DBIx schema update Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Patch pushed to master. Thanks Jonathan!