| Summary: | Item edit screen should use floating toolbar like cataloging interface | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Aleisha Amohia <aleisha> |
| Status: | In Discussion --- | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | aleisha, gmcharlt, jonathan.druart, kyle.m.hall, nick, veron |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2710 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400 |
||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 11088 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 11089: Add floating save button to item edit screen
Bug 11089: Add floating save button to item edit screen Bug 11089: Add floating save button to item edit screen |
||
|
Description
Owen Leonard
2013-10-20 20:01:55 UTC
Created attachment 50965 [details] [review] Bug 11089: Add floating save button to item edit screen It was agreed in Bug 11088 that the floating save panel is used when there are no other controls which need to be displayed in a toolbar. Thought it could be applied here. To test: 1) Apply 11088 first 2) Apply this patch 3) Go to edit an individual item 4) Confirm that Save panel floats in bottom right corner of page and stays in this position when browser is made to be narrower or wider Sponsored-by: Catalyst IT Created attachment 50970 [details] [review] Bug 11089: Add floating save button to item edit screen It was agreed in Bug 11088 that the floating save panel is used when there are no other controls which need to be displayed in a toolbar. Thought it could be applied here. To test: 1) Apply 11088 first 2) Apply this patch 3) Go to edit an individual item 4) Confirm that Save panel floats in bottom right corner of page and stays in this position when browser is made to be narrower or wider 5) Test with 2 active languages to ensure Save panel changes position to not be covered by language chooser Sponsored-by: Catalyst IT Created attachment 50981 [details] [review] Bug 11089: Add floating save button to item edit screen It was agreed in Bug 11088 that the floating save panel is used when there are no other controls which need to be displayed in a toolbar. Thought it could be applied here. To test: 1) Apply 11088 first 2) Apply this patch 3) Go to edit an individual item 4) Confirm that Save panel floats in bottom right corner of page and stays in this position when browser is made to be narrower or wider 5) Test with 2 active languages to ensure Save panel changes position to not be covered by language chooser Sponsored-by: Catalyst IT Signed-off-by: Marc Véron <veron@veron.ch> I personally don't like the floating button (same comment as on bug 11088). Especially since we can have the 2 ways to display buttons on the same view: when editing 1 item (floating button) and when adding a new item (old view with 3 buttons). (In reply to Jonathan Druart from comment #5) > Please see bug 16400 before QAing this patch. I guess I cast my vote by QAing 16400 - the styling seems more consistent. This feels slightly odd when the button floats above the items table on a record with a lot of items, perhaps if switched to the toolbar lock the highest point to the top of the form and only scroll down? That may be only personal opinion |