The floating toolbar, which keeps the "save" button at the top of the screen if the user scrolls down, should be added to the patron entry page so that the user is not required to scroll to the bottom to make changes midway through the page.
Created attachment 47939 [details] [review] Bug 11088: Floating toolbar to patron entry page ~ THIS IS NOT READY FOR SIGN OFF ~ Can someone who knows a bit about jquery (and maybe css) apply what I've got in this patch so far and work out why the toolbar keeps jumping down the page as soon as I scroll? The functionality of the toolbar and scrolling etc seems to work as it should, but I can't work out why it keeps jumping! Help appreciated!
After way too much time trying to figure this out, I was finally able to identify the problem: The additional patron search fields which are hidden when the page loads (<div id="filter">). Because the filter <div> is shown initially, the toolbar misidentifies where its starting location is on the page. My initial thought was to make the filter <div> hidden by default, but it's not that simple. I think if we want a floating toolbar on this page we have to re-think how the additional patron search fields are displayed.
The toolbar idea makes things difficult ... so I've come up with an idea that avoids it. How about a floating Save div that scrolls down the page with you?
Created attachment 50878 [details] [review] Bug 11088: Floating Save div for Patron entry page To test: 1) Go to add a new patron 2) Confirm floating save div scrolls down page with you and works as expected 3) Go to edit an existing patron 4) Repeat Step 2 Sponsored-by: Catalyst IT
Hi, I think we can improve it a bit. On a small screen resolution, like less than 100px, this floating div will look bad: http://i.imgur.com/VstAlk8.png However, this looks better: http://i.imgur.com/WE6k4LC.png And we can achieve the above (better) look by changing your style sheet to this: #save { background-color: rgba(185, 216, 217, 0.6); bottom: 3%; position: fixed; right: 1%; width: 150px; }
I think this looks like a good solution. I think we should rename the id something more specific, like "#floating_save" to avoid id duplication in case we want to use this on other pages. Now we need to think about how this fits into rules for how to design interfaces like this. When to use a floating toolbar and when to use a floating save "panel?" I'd like to have a better guideline than "we use the panel when the toolbar doesn't work." One possible way of thinking about it: The floating save panel is used when there are no other controls which need to be displayed in a toolbar. Arlsan do you want to submit a follow-up patch with your change?
Created attachment 50925 [details] [review] Bug 11088 [Follow up] - Patron entry page should use floating toolbar like cataloging interface To test: 1) Go to add a new patron 2) Confirm floating 'Save' button stays fixed at bottom right corner of the page as you scroll the page up/down 3) Resize the browser window to s smaller size, and see the 'Save' button stays fixed in place 3) Go to edit an existing patron 4) Repeat Step 2 and 3
There is a conflic after applying first patch, and again on second patch. CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
Created attachment 50935 [details] [review] [SIGNED-OFF] Bug 11088: Floating Save div for Patron entry page To test: 1) Go to add a new patron 2) Confirm floating save div scrolls down page with you and works as expected 3) Go to edit an existing patron 4) Repeat Step 2 Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 50936 [details] [review] [SIGNED-OFF] Bug 11088 [Follow up] - Patron entry page should use floating toolbar like cataloging interface To test: 1) Go to add a new patron 2) Confirm floating 'Save' button stays fixed at bottom right corner of the page as you scroll the page up/down 3) Resize the browser window to s smaller size, and see the 'Save' button stays fixed in place 3) Go to edit an existing patron 4) Repeat Step 2 and 3 Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Conflict was due to the old patch not being made obsolete. Thanks Aleisha and Arslan, this looks really good.
Please try it with 2 active languages in the staff interface - the new area than is partially hidden behind the language chooser!
Created attachment 50951 [details] Screenshot with language chooser hiding part of it
Sorry, not sure how best to fix it - failing for now and hoping for a speedy follow up - 11,5 hours left!
Created attachment 50966 [details] [review] Bug 11088: (QA followup) don't let language chooser obscure toolbar This uses a similar JS trick to the cataloging interface to change the location of the toolbar if the language picker is shown.
Created attachment 50967 [details] [review] [PASSED QA] Bug 11088: Floating Save div for Patron entry page To test: 1) Go to add a new patron 2) Confirm floating save div scrolls down page with you and works as expected 3) Go to edit an existing patron 4) Repeat Step 2 Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 50968 [details] [review] [PASSED QA] Bug 11088 [Follow up] - Patron entry page should use floating toolbar like cataloging interface To test: 1) Go to add a new patron 2) Confirm floating 'Save' button stays fixed at bottom right corner of the page as you scroll the page up/down 3) Resize the browser window to s smaller size, and see the 'Save' button stays fixed in place 3) Go to edit an existing patron 4) Repeat Step 2 and 3 Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 50969 [details] [review] [PASSED QA] Bug 11088: (QA followup) don't let language chooser obscure toolbar This uses a similar JS trick to the cataloging interface to change the location of the toolbar if the language picker is shown. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
*** Bug 9347 has been marked as a duplicate of this bug. ***
Created attachment 50984 [details] [review] Bug 11088 [QA Followup] - Add action icon for consistency Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed to master! Should be in the May 2016 release. Takk Aleisha!
In the cataloguing module we have the entire toolbar moving, and the save is at the top. When saving a patron, it will be at the bottom right. Should not we keep a consistency?
(In reply to Jonathan Druart from comment #22) > When saving a patron, it will be at the bottom right. > Should not we keep a consistency? Aleisha and I both tried to implement the floating toolbar for this bug in the same way that it is implemented elsewhere, but the hidden form fields in the search header make it difficult to implement the fixfloat() functionality correctly (See Comment 2). See Comment 6 for more comments on how this style of floating panel might fit into our guidelines.
(In reply to Owen Leonard from comment #23) > (In reply to Jonathan Druart from comment #22) > > When saving a patron, it will be at the bottom right. > > Should not we keep a consistency? > > Aleisha and I both tried to implement the floating toolbar for this bug in > the same way that it is implemented elsewhere, but the hidden form fields in > the search header make it difficult to implement the fixfloat() > functionality correctly (See Comment 2). I think I have managed to fix the issue on bug 16400, please have a look.