Bug 11092

Summary:	Need a processing fee and billing fee on late notices.
Product:	Koha	Reporter:	Blou <philippe.blouin>
Component:	Notices	Assignee:	Bugs List <koha-bugs>
Status:	RESOLVED DUPLICATE	QA Contact:	Testopia <testopia>
Severity:	enhancement
Priority:	P5 - low	CC:	francois.charbonnier, magnus, marjorie.barry-vila, nengard, viktor.sarge
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	---
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:
Circulation function:
Attachments:	Add a processing fee and billing fee on late notices Add a processing fee and billing fee on late notices Add a processing fee and billing fee on late notices Bug 11092 - Add invoice on overdue items

Description Blou 2013-10-21 13:41:03 UTC Comment hidden (obsolete)

Created attachment 22158 [details] [review]
Add a processing fee and billing fee  on late notices

This is a RFC, with a proof of concept.

Our client needed a billing fee (added to the total), a processing feed(added to each late item) and a default replacement fee, added to the Invoice sent to the patron.
Plus they needed to determine when to send the invoice (1st, 2nd or 3rd notice) so we modified overduerules.tt (along with overdue_notices.pl and overduerules.pl).

That change was made on Koha 3.10.  

**But community member kivilahtio  wanted to try it on the master.

So I attach the diffs/patches, below the DB instructions, and am now asking for feedbacks by the community on what feature would be needed by the community, before I bring it all cleanly to Master.

DB modifications:

alter table overduerules
  add invoice1 int(1) default 0 after debarred1,
  add invoice2 int(1) default 0 after debarred2,
  add invoice3 int(1) default 0 after debarred3;

insert into systempreferences values('InvoiceProcessingFee', 0, NULL, 'Invoice
processing fee (charged once per item)', 'Float'); 
insert into systempreferences values('InvoiceBillingFee', 0, NULL, 'Invoice
billing fee (charged once per bill)', 'Float'); 
insert into systempreferences values('DefaultReplacementPrice', 10.0, NULL,
'Amount to use when the item has none associated to it.', 'Float');

Comment 1 Blou 2013-10-21 13:41:39 UTC Comment hidden (obsolete)

Created attachment 22159 [details] [review]
Add a processing fee and billing fee  on late notices

Comment 2 Blou 2013-10-21 13:42:07 UTC Comment hidden (obsolete)

Created attachment 22160 [details] [review]
Add a processing fee and billing fee  on late notices

Comment 3 Mark Tompsett 2013-10-22 05:20:08 UTC

Comment on attachment 22159 [details] [review]
Add a processing fee and billing fee  on late notices

I suspect this hard-coded horror was replaced by templates. I don't know how to apply this to the current 3.10 series.

Comment 4 Mark Tompsett 2013-11-05 03:21:51 UTC

Blou, you may wish to rebase this, because I can't apply this to master or 3.10.12. Your patches are also not git-bz friendly. Patch 2 bombs badly when attempting to manually apply.

Comment 5 Blou 2013-11-05 13:04:13 UTC

Comment on attachment 22160 [details] [review]
Add a processing fee and billing fee  on late notices

I attached these for the benefit of kivi, but they cause too much confusion.  I'll redo them cleanly in the master.

Comment 6 Magnus Enger 2013-12-17 13:30:16 UTC

Hi Blou! Do you know when you might be able to submit this for master? I know someone who is very interested in testing it! :-)

Comment 7 Blou 2013-12-17 13:51:13 UTC

January, at the earliest.  I have a few such Koha items stacked up, I'll start working on them after the Holidays.  That's the plan, at least.

Comment 8 Magnus Enger 2013-12-17 14:03:39 UTC

(In reply to Blou from comment #7)
> January, at the earliest.  I have a few such Koha items stacked up, I'll
> start working on them after the Holidays.  That's the plan, at least.

Cool, thanks!

Comment 9 Magnus Enger 2014-05-22 14:34:42 UTC

(In reply to Blou from comment #7)
> January, at the earliest.  I have a few such Koha items stacked up, I'll
> start working on them after the Holidays.  That's the plan, at least.

I hate to nag, but is there a new timeline for this bug?

Comment 10 Viktor Sarge 2014-05-22 14:44:30 UTC

I would love to see this make it into Koha asap :) It sounds very much like the thing we need. The most important thing for me as of now is to know if it's on it's way or if it got buried under the other things that tend to pile up.

Comment 11 Blou 2014-06-06 21:26:33 UTC

Created attachment 28716 [details] [review]
Bug 11092 - Add invoice on overdue items

This is a draft for Viktor, to see where he needs the functionnality to go.
It was my first try with the letter mechanism, and I haven't managed (yet) to
get the email in HTML.  Much formatting is still needed.

See tools/letter.pl?op=add_form&branchcode=&module=circulation&code=INVOICE for new letter added by updatedatabase.pl

	modified:   ../../installer/data/mysql/updatedatabase.pl
	modified:   ../../koha-tmpl/intranet-tmpl/prog/en/modules/tools/overduerules.tt
	modified:   overdue_notices.pl
	modified:   ../../tools/overduerules.pl

http://bugs.koha-community.org/show_bug.cgi?id=10192

Comment 12 Blou 2014-06-26 20:25:40 UTC

NOTE: We'll be getting specs to upgrade the feature quite a bit.  So this will get a new patch somewhere in August.

Comment 13 Blou 2015-02-20 16:14:32 UTC

I'm not sure exactly how to close this, but this bz will never get further.
We have developped a much larger and improved solution described in
http://wiki.koha-community.org/wiki/Overdue_Notice_Enhancement#Enhancement_to_manage_more_than_3_levels_of_overdue_notice

The following bugzillas are involved for the various steps/patches:
#13624,#12768,#12769,#12770,#12771 and #12772.

That is where our energy is being put.

*** This bug has been marked as a duplicate of bug 12771 ***