| Summary: | undoing receiving does not appear to work (but actually does) | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Galen Charlton <gmcharlt> |
| Component: | Acquisitions | Assignee: | Bugs List <koha-bugs> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | jonathan.druart, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 11108: fix duplicate display of basket whose receipt has just been cancelled
[SIGN-OFF]Bug 11108: fix duplicate display of basket whose receipt has just been cancelled [PASSED QA] Bug 11108: fix duplicate display of basket whose receipt has just been cancelled |
||
|
Description
Galen Charlton
2013-10-22 00:10:29 UTC
Created attachment 22249 [details] [review] Bug 11108: fix duplicate display of basket whose receipt has just been cancelled After receiving an order basket, before finishing receiving the shipment, one has an option to cancel the receipt. This patch fixes a bug where a basket whose receipt was just cancelled displays on both the pending orders and already received tabs. This patch also fixes a minor unitialized variable warning. To test: [1] Create a basket with at least one order and close it. [2] Receive the order, then on the row in the 'Already received' table, click the cancel receipt link. [3] In the page that displays, the basket just cancelled displays on both tables. Clicking the cancel receipt link again results in an error message. [4] Apply the patch. [5] Repeat steps 1 and 2. This time, the cancelled basket displays only in the pending orders table, as expected. [6] Verify that after applying the patch, the following no longer is logged in the Apache error log: parcel.pl: Use of uninitialized value in string eq at acqui/parcel.pl line... Signed-off-by: Galen Charlton <gmc@esilibrary.com> Created attachment 22260 [details] [review] [SIGN-OFF]Bug 11108: fix duplicate display of basket whose receipt has just been cancelled After receiving an order basket, before finishing receiving the shipment, one has an option to cancel the receipt. This patch fixes a bug where a basket whose receipt was just cancelled displays on both the pending orders and already received tabs. This patch also fixes a minor unitialized variable warning. To test: [1] Create a basket with at least one order and close it. [2] Receive the order, then on the row in the 'Already received' table, click the cancel receipt link. [3] In the page that displays, the basket just cancelled displays on both tables. Clicking the cancel receipt link again results in an error message. [4] Apply the patch. [5] Repeat steps 1 and 2. This time, the cancelled basket displays only in the pending orders table, as expected. [6] Verify that after applying the patch, the following no longer is logged in the Apache error log: parcel.pl: Use of uninitialized value in string eq at acqui/parcel.pl line... Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Ed Veal <ed.veal@bywatersolutions.com> Created attachment 22441 [details] [review] [PASSED QA] Bug 11108: fix duplicate display of basket whose receipt has just been cancelled After receiving an order basket, before finishing receiving the shipment, one has an option to cancel the receipt. This patch fixes a bug where a basket whose receipt was just cancelled displays on both the pending orders and already received tabs. This patch also fixes a minor unitialized variable warning. To test: [1] Create a basket with at least one order and close it. [2] Receive the order, then on the row in the 'Already received' table, click the cancel receipt link. [3] In the page that displays, the basket just cancelled displays on both tables. Clicking the cancel receipt link again results in an error message. [4] Apply the patch. [5] Repeat steps 1 and 2. This time, the cancelled basket displays only in the pending orders table, as expected. [6] Verify that after applying the patch, the following no longer is logged in the Apache error log: parcel.pl: Use of uninitialized value in string eq at acqui/parcel.pl line... Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Ed Veal <ed.veal@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes test plan, all tests and QA script. Works as described. *** Bug 11128 has been marked as a duplicate of this bug. *** Pushed to master. This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Galen! |