Summary: | branch filter in budgets admin uses pattern match instead of equals | ||
---|---|---|---|
Product: | Koha | Reporter: | Fridolin Somers <fridolin.somers> |
Component: | Acquisitions | Assignee: | Fridolin Somers <fridolin.somers> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | gmcharlt, m.de.rooy, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
URL: | admin/aqbudgets.pl | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 11166 - branch filter in budgets admin uses pattern match instead of equals
Bug 11166 - branch filter in budgets admin uses pattern match instead of equals Bug 11166 - branch filter in budgets admin uses pattern match instead of equals |
Description
Fridolin Somers
2013-10-30 08:46:27 UTC
Created attachment 22573 [details] [review] Bug 11166 - branch filter in budgets admin uses pattern match instead of equals See commit message Created attachment 23566 [details] [review] Bug 11166 - branch filter in budgets admin uses pattern match instead of equals In budgets administration, admin/aqbudgets.pl, there is a combobox for filtering by branch code. The bug is that the filter uses a pattern match instead of equals : next unless $budget->{budget_branchcode} =~ m/$filter_budgetbranch/; In this case, if there is a branch with code '1' and one with code '12', filtering by branch '1' will also show budgets of branch '12'. Test plan : - Create a branch with code '1' and one with code '12' - Create budgets in both branches - Go to admin/aqbudgets.pl - Filter by branch '12' => You see only budgets of this branch - Filter by branch '1' => You see only budgets of this branch Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 23724 [details] [review] Bug 11166 - branch filter in budgets admin uses pattern match instead of equals In budgets administration, admin/aqbudgets.pl, there is a combobox for filtering by branch code. The bug is that the filter uses a pattern match instead of equals : next unless $budget->{budget_branchcode} =~ m/$filter_budgetbranch/; In this case, if there is a branch with code '1' and one with code '12', filtering by branch '1' will also show budgets of branch '12'. Test plan : - Create a branch with code '1' and one with code '12' - Create budgets in both branches - Go to admin/aqbudgets.pl - Filter by branch '12' => You see only budgets of this branch - Filter by branch '1' => You see only budgets of this branch Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Passes koha-qa.pl, works as advertised Pushed to master. Thanks, Fridolin! Patch pushed to 3.14.x, will be in 3.14.2 This patch has been pushed to 3.12.x, will be in 3.12.9. Thanks Fridolin! |