| Summary: | Borrowed items location show as "Not available" | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Chris Cormack <chris> |
| Component: | Circulation | Assignee: | Chris Cormack <chris> |
| Status: | CLOSED WONTFIX | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | ||
| Version: | 1.2.3 | ||
| Hardware: | PC | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Crowdfunding committed: | 0 |
| Crowdfunding contact: | Patch complexity: | --- | |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 32046: When adding a new records from a staged files, there are style issues
Bug 32046: (follow-up) Accommodate the inclusion of item information |
||
|
Description
Chris Cormack
2010-05-20 23:27:05 UTC
Created attachment 144033 [details] [review] Bug 32046: When adding a new records from a staged files, there are style issues This patch modifies the template for adding a record from a staged file in order to resolve some layout problems introduced by the staff redesign. This patch also corrects an problem with addorderiso2709.js: It included some template markup. The template variables are converted to a JS variable to prevent a JS error. Note that the QA tool's js_in_body error is invalid for this template which requires that the JS stay inside <head>. To test you must have at least one MARC file staged for import. - Apply the patch and go to Acquisitions. - Locate a vendor and create a basket if necessary. - Add to the basket and choose the option of adding an order from a staged file. - Click "Add orders" next to one of the staged files. - On the Add orders from MARC file page, test that everything looks correct and works correctly: - In the first tab, expanding and collapsing order details by checking the checkbox or clicking the title. - Test the "MARC" and "Card" preview buttons. - Under the Item information tab, confirm that the layout looks correct and that the form works correctly, including plugin operations like auto barcode fill. - Test that, under the Default accounting details tab, changing the fund automatically sets the fund for each title in the first tab. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 144034 [details] [review] Bug 32046: (follow-up) Accommodate the inclusion of item information If you have item information configured in the MarcItemFieldsToOrder system preference, the "Select to import" tab will display a basic item information form which needs to use the same style as other item edit forms. In order to make the CSS in addbiblio.css more generic, I've changed some styles to use a class, .item_edit_form, instead of an ID. This lets us have multiple <div class="item_edit_form"> in this template without duplicating IDs. Other instances of <div id="cataloguing_additem_newitem"> have haa the .item_edit_form class added. To test you must have a staged MARC file which includes items and you must configure the MarcItemFieldsToOrder preference to map those items in the ordering interface. As you follow the previous patch's test plan you'll find that when you click a checkbox or title to expand the information about that title you'll see "Item record X" headings following by a properly-styled form. To confirm that the changes to addbiblio.css are not too far-reaching, test the other affected pages: - Item add/edit - Batch item modification - Batch item deletion Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> |