Bug 112 - Borrowed items location show as "Not available"
Summary: Borrowed items location show as "Not available"
Status: CLOSED WONTFIX
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: 1.2.3
Hardware: PC All
: P3 normal
Assignee: Chris Cormack
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-10-25 06:20 UTC by Chris Cormack
Modified: 2022-11-17 20:14 UTC (History)
0 users

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Comma delimited list of Sponsors:
Crowdfunding goal: 0
Crowdfunding committed: 0
Crowdfunding contact:
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 32046: When adding a new records from a staged files, there are style issues (67.68 KB, patch)
2022-11-17 19:57 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32046: (follow-up) Accommodate the inclusion of item information (48.90 KB, patch)
2022-11-17 19:57 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-20 23:27:05 UTC


---- Reported by vhuhtala@paju.oulu.fi 2002-10-25 06:20:45 ----

Borrowed items location show as "Not available" - it should say "In Circulation".



---- Additional Comments From tonnesen@cmsd.bc.ca 2002-10-25 06:24:18 ----

Or maybe "On Loan"



---- Additional Comments From Ilacis@chillco.com 2003-03-29 09:55:08 ----

In version 1.90 it says "On Loan"



---- Additional Comments From rachel@katipo.co.nz 2003-09-03 12:00:04 ----

I think this is a "won't fix" as it's been fixed in a later version, and it's 
not worth doing another release of 1.2x for it.



--- Bug imported by chris@bigballofwax.co.nz 2010-05-20 23:27 UTC  ---

This bug was previously known as _bug_ 112 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=112

Actual time not defined. Setting to 0.0
The original reporter of this bug does not have
   an account here. Reassigning to the person who moved
   it here: chris@bigballofwax.co.nz.
   Previous reporter was vhuhtala@paju.oulu.fi.

Comment 1 Katrin Fischer 2022-11-17 19:57:23 UTC
Created attachment 144033 [details] [review]
Bug 32046: When adding a new records from a staged files, there are style issues

This patch modifies the template for adding a record from a staged file
in order to resolve some layout problems introduced by the staff
redesign.

This patch also corrects an problem with addorderiso2709.js: It included
some template markup. The template variables are converted to a JS
variable to prevent a JS error.

Note that the QA tool's js_in_body error is invalid for this template
which requires that the JS stay inside <head>.

To test you must have at least one MARC file staged for import.

- Apply the patch and go to Acquisitions.
- Locate a vendor and create a basket if necessary.
- Add to the basket and choose the option of adding an order from a
  staged file.
- Click "Add orders" next to one of the staged files.
- On the Add orders from MARC file page, test that everything looks
  correct and works correctly:
  - In the first tab, expanding and collapsing order details by checking
    the checkbox or clicking the title.
  - Test the "MARC" and "Card" preview buttons.
  - Under the Item information tab, confirm that the layout looks
    correct and that the form works correctly, including plugin
    operations like auto barcode fill.
  - Test that, under the Default accounting details tab, changing the
    fund automatically sets the fund for each title in the first tab.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 2 Katrin Fischer 2022-11-17 19:57:27 UTC
Created attachment 144034 [details] [review]
Bug 32046: (follow-up) Accommodate the inclusion of item information

If you have item information configured in the MarcItemFieldsToOrder
system preference, the "Select to import" tab will display a basic item
information form which needs to use the same style as other item edit
forms.

In order to make the CSS in addbiblio.css more generic, I've changed
some styles to use a class, .item_edit_form, instead of an ID. This lets
us have multiple <div class="item_edit_form"> in this template without
duplicating IDs. Other instances of <div
id="cataloguing_additem_newitem"> have haa the .item_edit_form class
added.

To test you must have a staged MARC file which includes items and you
must configure the MarcItemFieldsToOrder preference to map those items
in the ordering interface.

As you follow the previous patch's test plan you'll find that when you
click a checkbox or title to expand the information about that title
you'll see "Item record X" headings following by a properly-styled form.

To confirm that the changes to addbiblio.css are not too far-reaching,
test the other affected pages:

 - Item add/edit
 - Batch item modification
 - Batch item deletion

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>