Bug 11208

Summary: Multi transport types: a sms message without sms number should be marked as failed
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: ToolsAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: gmcharlt
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 9016    
Bug Blocks: 11209    
Attachments: Bug 11208: If no smsalertnumber is defined, the message is marked as failed
Bug 11208: If no smsalertnumber is defined, the message is marked as failed
[PASSED QA] Bug 11208: If no smsalertnumber is defined, the message is marked as failed

Description Jonathan Druart 2013-11-06 14:22:45 UTC

    
Comment 1 Jonathan Druart 2013-11-06 14:23:17 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2013-12-27 20:52:17 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2013-12-28 14:51:47 UTC
Created attachment 23841 [details] [review]
[PASSED QA] Bug 11208: If no smsalertnumber is defined, the message is marked as failed

For DUE message (and PREDUE, etc.) there are no check before sending the
message to the message_queue table.

This check avoids to try to send again and again the same message. Now
it is marked as "failed".

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Without the patch a sms notice will remain as 'pending' forever.
With the patch applied, the status is set to 'failed'.

Passes all tests and QA script.
Comment 4 Galen Charlton 2013-12-30 16:49:16 UTC
Pushed to master, along with a patch that adds a regression test.  Thanks, Jonathan!