Summary: | typo in modborrowers.tt javascript string | ||
---|---|---|---|
Product: | Koha | Reporter: | Fridolin Somers <fridolin.somers> |
Component: | Tools | Assignee: | Fridolin Somers <fridolin.somers> |
Status: | CLOSED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
Severity: | normal | ||
Priority: | P5 - low | CC: | gmcharlt, jonathan.druart, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | String patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 8986 | ||
Bug Blocks: | |||
Attachments: |
Bug 11245 - typo in modborrowers.tt javascript string
Bug 11245 - typo in modborrowers.tt javascript string [SIGNED-OFF] Bug 11245 - typo in modborrowers.tt javascript string Bug 11245 - typo in modborrowers.tt javascript string |
Description
Fridolin Somers
2013-11-13 15:28:54 UTC
Created attachment 22909 [details] [review] Bug 11245 - typo in modborrowers.tt javascript string Trivial patch Please provide a test plan. How do you trigger that error message? Created attachment 22938 [details] [review] Bug 11245 - typo in modborrowers.tt javascript string Test plan added Created attachment 22939 [details] [review] [SIGNED-OFF] Bug 11245 - typo in modborrowers.tt javascript string In modborrowers.tt, Bug 8986 made the javascript strings translatable : _("This attribute will be only applied to the patron\'s category") In this case, the backslash is useless. Test plan : - Create a borrower attribute with a "Category" defined - Go to Tools / Batch patrons modification - Enter a cardnumber and submit - Next to "Attribute", select the borrower attribute you created => You see a grey text at the right : This attribute will be only applied to the patron's category "XXX" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Work as before : the backslash was not displayed. Marked as Passed QA. Created attachment 23069 [details] [review] Bug 11245 - typo in modborrowers.tt javascript string In modborrowers.tt, Bug 8986 made the javascript strings translatable : _("This attribute will be only applied to the patron\'s category") In this case, the backslash is useless. Test plan : - Create a borrower attribute with a "Category" defined - Go to Tools / Batch patrons modification - Enter a cardnumber and submit - Next to "Attribute", select the borrower attribute you created => You see a grey text at the right : This attribute will be only applied to the patron's category "XXX" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Pushed to master. Thanks, Fridolin! This patch has been pushed to 3.14.x, will be in 3.14.1 This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Fridolin! |