Bug 11245 - typo in modborrowers.tt javascript string
Summary: typo in modborrowers.tt javascript string
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Fridolin Somers
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on: 8986
Blocks:
  Show dependency treegraph
 
Reported: 2013-11-13 15:28 UTC by Fridolin Somers
Modified: 2015-06-04 23:23 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11245 - typo in modborrowers.tt javascript string (1.44 KB, patch)
2013-11-13 15:30 UTC, Fridolin Somers
Details | Diff | Splinter Review
Bug 11245 - typo in modborrowers.tt javascript string (1.75 KB, patch)
2013-11-14 16:05 UTC, Fridolin Somers
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 11245 - typo in modborrowers.tt javascript string (1.84 KB, patch)
2013-11-14 16:27 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 11245 - typo in modborrowers.tt javascript string (1.86 KB, patch)
2013-11-21 16:08 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin Somers 2013-11-13 15:28:54 UTC
In modborrowers.tt, Bug 8986 made the javascript strings translatable : 
  _("This attribute will be only applied to the patron\'s category")
In this case, the backslash is useless.
Comment 1 Fridolin Somers 2013-11-13 15:30:53 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2013-11-14 15:26:09 UTC
Please provide a test plan. How do you trigger that error message?
Comment 3 Fridolin Somers 2013-11-14 16:05:12 UTC Comment hidden (obsolete)
Comment 4 Owen Leonard 2013-11-14 16:27:56 UTC Comment hidden (obsolete)
Comment 5 Jonathan Druart 2013-11-21 16:07:58 UTC
Work as before : the backslash was not displayed.
Marked as Passed QA.
Comment 6 Jonathan Druart 2013-11-21 16:08:13 UTC
Created attachment 23069 [details] [review]
Bug 11245 - typo in modborrowers.tt javascript string

In modborrowers.tt, Bug 8986 made the javascript strings translatable :
  _("This attribute will be only applied to the patron\'s category")
In this case, the backslash is useless.

Test plan :
- Create a borrower attribute with a "Category" defined
- Go to Tools / Batch patrons modification
- Enter a cardnumber and submit
- Next to "Attribute", select the borrower attribute you created
=> You see a grey text at the right : This attribute will be only applied to the patron's category "XXX"

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 7 Galen Charlton 2013-11-21 17:40:31 UTC
Pushed to master.  Thanks, Fridolin!
Comment 8 Fridolin Somers 2013-12-13 07:50:37 UTC
This patch has been pushed to 3.14.x, will be in 3.14.1
Comment 9 Tomás Cohen Arazi 2013-12-16 13:37:38 UTC
This patch has been pushed to 3.12.x, will be in 3.12.8.

Thanks Fridolin!