Description
Jonathan Druart
2013-11-14 12:58:10 UTC
Created attachment 22927 [details] [review] Bug 11248: Encoding issue on sending a list (OPAC) See bug 10605 for more details. Test plan: - send a list via email with the english version. - translate templates and retry with another language. Created attachment 22928 [details] [review] Bug 11248: Encoding issue on sending a list (INTRANET) Created attachment 22929 [details] [review] Bug 11248: Encoding issue on sending a list (OPAC) See bug 10605 for more details. Test plan: - send a list via email with the english version. - translate templates and retry with another language. This is a bit confusing. without the patch the translated Email has 'no subject' and no content, but I thought that had been fixed a while ago? With the patch applied, the line breaks are missing: Guten Tag, dies ist Ihre Liste TEST, die Sie sich aus unserem Online-Katalog zugeschickt haben. Bitte beachten Sie, dass es sich bei der angehängten Datei um Daten im bibliographischen MARC-Format handelt, dass Sie in eine persönliche Literaturverwaltungssoftware wie EndNote, Reference Manager oder ProCite importieren können. --------------------------------------------- Der Tagesspiegel : Weitere Verfasser: Reger, Erik Verlag: Verl. Der Tagesspiegel, 57 Fußnoten: Begr.: Erik Reger, Walther Karsch, Edwin Redslob; Mitbegr.: Peter de Mendelssohn; Hrsg.: Hellmuth Karasek, Hermann Rudolph; 1949 - 1984: Franz Karl Maier, Heik Afheldt; ab 2004,Aug.: Giovanni di Lorenzo; verantw. Red. bis 2004,Juli: Giovanni di Lorenzo; Verleger ab ca. 1993: Dieter von Holtzbrinck. Amerikan. Lizenz: Nr. 16; ZKZ: 6622; Relaunch: 1994, 2.Sept. u. 1999, 23.Mai. Exemplar(e) : --------------------------------------------- Die Weltwoche Verlag: Weltwoche-Verl. | Die Weltwoche c/o Jean Frey AG,, 57 Exemplar(e) : --------------------------------------------- Südkurier : Verlag: Südkurier, 57 Fußnoten: VKZ: E 6576. Exemplar(e) : --------------------------------------------- The broken umlauts in that example go away, when I tell Thunderbird that the encoding is UTF-8 - is there a way to make it autodetect that correctly? (That's for staff). Created attachment 22980 [details] [review] Bug 11248: Follow up - Fix template for translated list emails in staff Copied over the template changes done for the OPAC to the staff template. To test: - Update and install translation files - Send yourself a shelf from the staff interface vie email - Check formatting and links are correct Created attachment 22981 [details] [review] [SIGNED OFF] Bug 11248: Encoding issue on sending a list (INTRANET) Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Sending an intranet list from translated templates requires a new list template for the intranet. I have added the needed changes in a follow-up. Created attachment 22982 [details] [review] [SIGNED OFF] Bug 11248: Encoding issue on sending a list (OPAC) See bug 10605 for more details. Test plan: - send a list via email with the english version. - translate templates and retry with another language. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works nicely. Links to the OPAC are correct. Created attachment 22983 [details] [review] Bug 11248: Follow up - Fix template for translated list emails in staff Copied over the template changes done for the OPAC to the staff template. To test: - Update and install translation files - Send yourself a shelf from the staff interface vie email - Check formatting and links are correct Hi Jonathan, could you take a look at my follow up? The list emails from staff were missing the template changes needed to make them survive the translation scripts unharmed :) Created attachment 22984 [details] [review] Bug 11248: Follow up - Fix template for translated list emails in staff Copied over the template changes done for the OPAC to the staff template. To test: - Update and install translation files - Send yourself a shelf from the staff interface vie email - Check formatting and links are correct Removes reference to [% BIBLIO_RESULT.size %], because with TT this will be the count of elements instead of the content of the field. (In reply to Katrin Fischer from comment #9) > Hi Jonathan, could you take a look at my follow up? > > The list emails from staff were missing the template changes needed to make > them survive the translation scripts unharmed :) I agree with the call to the url filter. But I am not sure the others changes is needed: - [% IF BIBLIO_RESULT.size %] - , [% BIBLIO_RESULT.size %] - [% END %] Why do you remove these lines? - In online catalog: [% OPACBaseURL %]/cgi-bin/koha/opac-detail.pl?biblionumber=[% BIBLIO_RESULT.biblionumber %] + In online catalog: http://[% OPACBaseURL %]/cgi-bin/koha/opac-detail.pl?biblionumber=[% BIBLIO_RESULT.biblionumber %] Why do you add the http before the OPACBaseURL? It does not exist in others places? Hi Jonathan, 2 good questions - and I should have explained the changes better. I removed the [% BIBLIO_RESULT.size %] because the information it should display is not super important and it won't display currently. For TT size means to count the number of elements (I noticed that it was always 57 or something like that in my tests) and not the content of the database field. This is not an important, please undo it if you want, or I can do it, but not before much later tonight. I added the http:// because without the link was not working and appeared incomplete. Actually you are right and I should have looked into it more to see why it does not happen in the OPAC, there is also a bug for it (bug 5010). But why does it not happen on OPAC? I think I found the difference that is causing the problems with the URL, but I will fix those on a separate bug. I will remove both changes Jonathan thought were suspicious (and he was right of course :) from my follow-up). Created attachment 23360 [details] [review] Bug 11248: Follow up - Fix template for translated list emails in staff - Fixes some capitalization problems - Adds an URL filter I messed up a bit here, hope the redone follow-up makes more sense. Could you take a look Jonathan and switch to Signed off if it's ok? If the follow-up gives problems just obsolete it. Created attachment 23369 [details] [review] [SIGNED OFF] Bug 11248: Follow up - Fix template for translated list emails in staff - Fixes some capitalization problems - Adds an URL filter Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Katrin, Thank you the followup. It looks good now :) for* Note that someone other than Katrin and me is needed to QA these patches. Created attachment 24140 [details] [review] Bug 11248: Encoding issue on sending a list (INTRANET) Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Sending an intranet list from translated templates requires a new list template for the intranet. I have added the needed changes in a follow-up. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 24141 [details] [review] Bug 11248: Encoding issue on sending a list (OPAC) See bug 10605 for more details. Test plan: - send a list via email with the english version. - translate templates and retry with another language. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works nicely. Links to the OPAC are correct. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 24142 [details] [review] Bug 11248: Follow up - Fix template for translated list emails in staff - Fixes some capitalization problems - Adds an URL filter Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> This is a major. The received email is empty and the subject is "no subject" on master. I agree. Pushed to master. Thanks, Jonathan! Pushed to 3.14.x, will be in 3.14.10 Picked for 3.12.15! |