I spotted some problems with sending cart emails from the OPAC: There is a problem with encoding, as the umlauts in the translated German message are broken. The first paragraph is repeated and the list of items is completely missing. I have seen this happening on 3.12.1 - would be glad if someone could test and confirm on their installation.
Encoding problem also in 3.12.4
Created attachment 21428 [details] [review] Proposed patch Suppress a double-encoding
Still seeing this in 3.12.6 - missed checking this bug again :(
I haven't figured out why yet, but with the patch applied, my links from the cart email to the records in the OPAC are missing the biblionumber. On master it seems ok.
Frederic, could you take a look at the links? I am a bit puzzled why your patch would make a difference there. Example: In online catalog: http://localhost/cgi-bin/koha/opac-detail.pl?biblionumber=
I think it might be the combination of = and a number that is doing it. I remember seeing problems with that somewhere else, but I can't find it now.
Found this: http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=696fc0ff22fac839e97b9f9caddda99ff89d9ffc
Katrin: which email client are you using? For me, it works with Thunderbird and Gmail.
I am using Thunderbird
It could be something in the settings of course, but I think I am using pretty much the standard there. I noticed that I had to manually switch to utf-8 to make the umlauts show correctly as the automatic detection didn't seem to work - might be my settings or some deeper issue?
> It could be something in the settings of course, but I think I am using > pretty much the standard there. I noticed that I had to manually switch to > utf-8 to make the umlauts show correctly as the automatic detection didn't > seem to work - might be my settings or some deeper issue? You server mailer could be the culprit. Which SMTP server are you using? I conduct my tests on a Koha server that runs Exim4.
I have to admit that I am not sure and can't check right now - someone else set up mailing for me on my laptop and I was happy to never have to touch it since. Maybe we can get some others testing this and compare results?
My tests: Without the patch (on the master branch): Hum... the received mail is really weird: Bonjour, JOUBU vous a envoyé un panier de références extraites de notre catalogue. Notez que le fichier attaché est un fichier MARC, qui peut être importé dans un logiciel de gestion de bibliographie tel que EndNote, Reference Manager ou ProCite. --------------------------------------------------------------------- Bonjour, JOUBU vous a envoyé un panier de références extraites de notre catalogue. Notez que le fichier attaché est un fichier MARC, qui peut être importé dans un logiciel de gestion de bibliographie tel que EndNote, Reference Manager ou ProCite. --------------------------------------------------------------------- With the patch: Bonjour, JOUBU vous a envoyé un panier de références extraites de notre catalogue. Notez que le fichier attaché est un fichier MARC, qui peut être importé dans un logiciel de gestion de bibliographie tel que EndNote, Reference Manager ou ProCite. --------------------------------------------------------------------- un message personnalisé pour toi --------------------------------------------------------------------- 1. I love english junior Auteur(s) : Bruno FRAPPAT ; Frappat --Bruno -- Directeur de la pub Publié par : Bayard-presse , 57 Dans le catalogue : http://opac.koha_coderun.localhost/cgi-bin/koha/opac-detail.pl?biblionumber9 Exemplaires : * Le Cannet Documentaires adulte 00519000164128 All looks good, except the link url.
Created attachment 22925 [details] [review] Bug 10605: Encoding issue on sending a basket (OPAC) There is an encoding issue on the received mail. Here, we have to keep the encode_qp in order not to break links (= is a special char for email https://en.wikipedia.org/wiki/MIME#Encoded-Word). I don't understand why I have to decode the string before the call to encode_qp but it is the only way not to have encoding issue...
Created attachment 22926 [details] [review] Bug 10605: Encoding issue on sending a basket (INTRANET) Same fix for the staff interface.
With the last patch, I get: Bonjour, JOUBU vous a envoyé un panier de références extraites de notre catalogue. Notez que le fichier attaché est un fichier MARC, qui peut être importé dans un logiciel de gestion de bibliographie tel que EndNote, Reference Manager ou ProCite. --------------------------------------------------------------------- opac testé --------------------------------------------------------------------- 1. Pays de Provence Côte d'Azur Auteur(s) : Richard Clavaud ; Clavaud --Richard -- Directeur de la pub Publié par : Milan presse , 57 Dans le catalogue : http://opac.koha_coderun.localhost/cgi-bin/koha/opac-detail.pl?biblionumber=13
This is a major bug, it should be in 3.14. Please test!
I am sorry, but this is still giving me trouble. For the intranet: Software error: Undefined subroutine &main::decode called at /home/katrin/kohaclone/basket/sendbasket.pl line 136. For help, please send mail to the webmaster (webmaster@bumblebee), giving this error message and the time and date of the error. And in OPAC: In the received email, the introduction text has broken umlauts, but the title information is ok (tested in Thunderbird). When I switch the encoding to utf-8, the introduction text is ok, but the umlauts in the title information are broken. It looks to me, like we have a mix now.
Created attachment 22996 [details] [review] Bug 10605: Encoding issue on sending a basket (INTRANET) Same fix for the staff interface.
(In reply to Katrin Fischer from comment #18) > I am sorry, but this is still giving me trouble. > > For the intranet: > Software error: Last patch fixes this error.
Created attachment 22998 [details] [review] Bug 10605: Encoding issue on sending a basket (OPAC) There is an encoding issue on the received mail. Here, we have to keep the encode_qp in order not to break links (= is a special char for email https://en.wikipedia.org/wiki/MIME#Encoded-Word).
Created attachment 22999 [details] [review] Bug 10605: Encoding issue on sending a basket (INTRANET) Same fix for the staff interface.
(In reply to Katrin Fischer from comment #18) > And in OPAC: > In the received email, the introduction text has broken umlauts, but the > title information is ok (tested in Thunderbird). When I switch the encoding > to utf-8, the introduction text is ok, but the umlauts in the title > information are broken. It looks to me, like we have a mix now. Reproduced using icedove (~ Thunderbird). I don't occurs encoding issue with the 2 last patches. Could you retest please?
Created attachment 23018 [details] [review] [SIGNED OFF] Bug 10605: Encoding issue on sending a basket (OPAC) There is an encoding issue on the received mail. Here, we have to keep the encode_qp in order not to break links (= is a special char for email https://en.wikipedia.org/wiki/MIME#Encoded-Word). Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Created attachment 23019 [details] [review] [SIGNED OFF] Bug 10605: Encoding issue on sending a basket (INTRANET) Same fix for the staff interface. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Both patches tested with English and German, diacritics now appear correctly if UTF-8 is selected as encoding. Passes all tests and QA script.
NOTE: The staff cart email is missing the links back to the OPAC - but that is on master and with the patches, so another bug.
Created attachment 23044 [details] [review] [PASSED-QA] Bug 10605: Encoding issue on sending a basket (OPAC) There is an encoding issue on the received mail. Here, we have to keep the encode_qp in order not to break links (= is a special char for email https://en.wikipedia.org/wiki/MIME#Encoded-Word). Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Created attachment 23045 [details] [review] Bug 10605: Encoding issue on sending a basket (OPAC) There is an encoding issue on the received mail. Here, we have to keep the encode_qp in order not to break links (= is a special char for email https://en.wikipedia.org/wiki/MIME#Encoded-Word). Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Created attachment 23046 [details] [review] [PASSED-QA] Bug 10605: Encoding issue on sending a basket (INTRANET) Same fix for the staff interface. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Both patches tested with English and German, diacritics now appear correctly if UTF-8 is selected as encoding. Passes all tests and QA script. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Pushed to master. Thanks, Jonathan!
Patches pushed to 3.14.x, will be in 3.14.2.
NB : looking at opac-sendbasket.pl and sendbasket.pl, I noticed that nearly all code is identical. This should be moved in a module.
(In reply to Fridolin SOMERS from comment #32) > NB : looking at opac-sendbasket.pl and sendbasket.pl, I noticed that nearly > all code is identical. This should be moved in a module. Indeed: see bug 11443. Thks.
This patch has been pushed to 3.12.x, will be in 3.12.9. Thanks Jonathan!