|
Description
Katrin Fischer
2013-11-17 21:09:31 UTC
Created attachment 23036 [details] [review] Bug 11261: Sample frequencies and numbering patterns should better be mandatory on install Test plan: Verify all sample_numberpatterns.* files have been moved from optional to mandatory directories. Created attachment 23325 [details] [review] [SIGNED OFF] Bug 11261: Sample frequencies and numbering patterns should better be mandatory on install Test plan: Verify all sample_numberpatterns.* files have been moved from optional to mandatory directories. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All sample files for numbering patterns are moved from optional to mandatory. Hi Jonathan, the first patch is ok, but you are only moving the numbering patterns - what do you think about also moving the frequencies? (sample_frequencies.txt/.sql) Created attachment 23340 [details] [review] Bug 11261: Sample numbering patterns should better be mandatory on install Test plan: Verify all sample_numberpatterns.* files have been moved from optional to mandatory directories. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All sample files for numbering patterns are moved from optional to mandatory. Created attachment 23341 [details] [review] Bug 11261: Sample frequencies should better be mandatory on install Test plan: Verify all sample_frequencies.* files have been moved from optional to mandatory directories. (In reply to Katrin Fischer from comment #3) > Hi Jonathan, > the first patch is ok, but you are only moving the numbering patterns - what > do you think about also moving the frequencies? (sample_frequencies.txt/.sql) Yes of course, second patch does that. Created attachment 23437 [details] [review] Bug 11261: make sample serial numbering patterns mandatory during installation Test plan: Verify all sample_numberpatterns.* files have been moved from optional to mandatory directories. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All sample files for numbering patterns are moved from optional to mandatory. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Created attachment 23438 [details] [review] Bug 11261: make sample serial frequencies mandatory during installation Test plan: Verify all sample_frequencies.* files have been moved from optional to mandatory directories. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Created attachment 23534 [details] [review] Bug 11261: make sample serial numbering patterns mandatory during installation Test plan: Verify all sample_numberpatterns.* files have been moved from optional to mandatory directories. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All sample files for numbering patterns are moved from optional to mandatory. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 23535 [details] [review] Bug 11261: make sample serial frequencies mandatory during installation Test plan: Verify all sample_frequencies.* files have been moved from optional to mandatory directories. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to master. Thanks, Jonathan! Patches pushed to 3.14.x, will be in 3.14.2 |