When you update the subscription table, checking patterns has a bad behaviour because this process compares patterns (new versus just created) without considering NULL values. The result is a lot of patterns duplicated in 'subscription_numberpatterns' table.
Created attachment 23177 [details] [review] Bug 11309 - Duplicated patterns when subscription table is updated This patch solves the bug.
Created attachment 24004 [details] [review] [SIGNED-OFF] Bug 11309: Duplicated patterns when subscription table is updated Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Steps to reproduce the problem: 1/ Install Koha 3.12 2/ Create some subscriptions. Ensure you have at least two subscriptions with the same numbering pattern, with one of the keys everyX/addX/whenmorethanX/settoX set to NULL 3/ Remember this numbering pattern. 4/ Upgrade to 3.14 5/ Run updatedatabase.pl 6/ The numbering pattern is duplicated Now repeat steps 1 to 4, then apply the patch and run updatedatabase.pl. Numbering pattern should not be duplicated.
Maybe this need another patch to remove already created duplicates (maybe only those whose name starts with 'Backup pattern') ?
Created attachment 24495 [details] [review] Bug 11309: Duplicated patterns when subscription table is updated Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed to master. Thanks, Nuño!