| Summary: | Biblioitems URL field is too small for some URLs | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Kyle M Hall (khall) <kyle> |
| Component: | Architecture, internals, and plumbing | Assignee: | Kyle M Hall (khall) <kyle> |
| Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | dcook, gmcharlt, m.de.rooy |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 11268 - Biblioitems URL field is too small for some URLs
Bug 11268 - Biblioitems URL field is too small for some URLs Bug 11268 - Biblioitems URL field is too small for some URLs |
||
|
Description
Kyle M Hall (khall)
2013-11-18 19:17:39 UTC
Created attachment 23006 [details] [review] Bug 11268 - Biblioitems URL field is too small for some URLs The URL field in biblioitems is defined as a varchar(255) which is large enough for most URLs but not all. This field should be converted to a TEXT field to make sure it is capable of storing all valid URLs. Test Plan: 1) Attempt to a URL that is greater than 255 chacters long in a record (856$u in MARC21) 2) Save the record, note the url gets truncated 3) Apply this patch 4) Repeat step 1 5) Note the entire url is saved Created attachment 24741 [details] [review] Bug 11268 - Biblioitems URL field is too small for some URLs The URL field in biblioitems is defined as a varchar(255) which is large enough for most URLs but not all. This field should be converted to a TEXT field to make sure it is capable of storing all valid URLs. Test Plan: 1) Attempt to a URL that is greater than 255 chacters long in a record (856$u in MARC21) 2) Save the record, note the url gets truncated 3) Apply this patch 4) Repeat step 1 5) Note the entire url is saved Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Created attachment 24925 [details] [review] Bug 11268 - Biblioitems URL field is too small for some URLs The URL field in biblioitems is defined as a varchar(255) which is large enough for most URLs but not all. This field should be converted to a TEXT field to make sure it is capable of storing all valid URLs. Test Plan: 1) Attempt to a URL that is greater than 255 chacters long in a record (856$u in MARC21) 2) Save the record, note the url gets truncated 3) Apply this patch 4) Repeat step 1 5) Note the entire url is saved Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed to master. Thanks, Kyle! Hurray! Glad to see this was changed to long ago. Looks like items.uri is still stuck at 255 characters, but I'll open up a separate bug report for that... |