Bug 11268 - Biblioitems URL field is too small for some URLs
Summary: Biblioitems URL field is too small for some URLs
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Kyle M Hall
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-18 19:17 UTC by Kyle M Hall
Modified: 2020-02-07 01:26 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11268 - Biblioitems URL field is too small for some URLs (2.92 KB, patch)
2013-11-18 19:20 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 11268 - Biblioitems URL field is too small for some URLs (2.97 KB, patch)
2014-01-27 11:44 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 11268 - Biblioitems URL field is too small for some URLs (3.07 KB, patch)
2014-01-31 10:21 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2013-11-18 19:17:39 UTC
The URL field in biblioitems is defined as a varchar(255) which is large enough for most URLs but not all. This field should be converted to a TEXT field to make sure it is capable of storing all valid URLs.
Comment 1 Kyle M Hall 2013-11-18 19:20:09 UTC Comment hidden (obsolete)
Comment 2 Jonathan Druart 2014-01-27 11:44:42 UTC Comment hidden (obsolete)
Comment 3 Marcel de Rooy 2014-01-31 10:21:54 UTC
Created attachment 24925 [details] [review]
Bug 11268 - Biblioitems URL field is too small for some URLs

The URL field in biblioitems is defined as a varchar(255) which is large
enough for most URLs but not all. This field should be converted to a
TEXT field to make sure it is capable of storing all valid URLs.

Test Plan:
1) Attempt to a URL that is greater than 255 chacters long in a record
   (856$u in MARC21)
2) Save the record, note the url gets truncated
3) Apply this patch
4) Repeat step 1
5) Note the entire url is saved

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Galen Charlton 2014-01-31 16:03:26 UTC
Pushed to master.  Thanks, Kyle!
Comment 5 David Cook 2020-02-07 01:26:25 UTC
Hurray! 

Glad to see this was changed to long ago.

Looks like items.uri is still stuck at 255 characters, but I'll open up a separate bug report for that...