The URL field in biblioitems is defined as a varchar(255) which is large enough for most URLs but not all. This field should be converted to a TEXT field to make sure it is capable of storing all valid URLs.
Created attachment 23006 [details] [review] Bug 11268 - Biblioitems URL field is too small for some URLs The URL field in biblioitems is defined as a varchar(255) which is large enough for most URLs but not all. This field should be converted to a TEXT field to make sure it is capable of storing all valid URLs. Test Plan: 1) Attempt to a URL that is greater than 255 chacters long in a record (856$u in MARC21) 2) Save the record, note the url gets truncated 3) Apply this patch 4) Repeat step 1 5) Note the entire url is saved
Created attachment 24741 [details] [review] Bug 11268 - Biblioitems URL field is too small for some URLs The URL field in biblioitems is defined as a varchar(255) which is large enough for most URLs but not all. This field should be converted to a TEXT field to make sure it is capable of storing all valid URLs. Test Plan: 1) Attempt to a URL that is greater than 255 chacters long in a record (856$u in MARC21) 2) Save the record, note the url gets truncated 3) Apply this patch 4) Repeat step 1 5) Note the entire url is saved Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 24925 [details] [review] Bug 11268 - Biblioitems URL field is too small for some URLs The URL field in biblioitems is defined as a varchar(255) which is large enough for most URLs but not all. This field should be converted to a TEXT field to make sure it is capable of storing all valid URLs. Test Plan: 1) Attempt to a URL that is greater than 255 chacters long in a record (856$u in MARC21) 2) Save the record, note the url gets truncated 3) Apply this patch 4) Repeat step 1 5) Note the entire url is saved Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed to master. Thanks, Kyle!
Hurray! Glad to see this was changed to long ago. Looks like items.uri is still stuck at 255 characters, but I'll open up a separate bug report for that...