Bug 11309

Summary: Duplicated patterns when subscription table is updated
Product: Koha Reporter: Nuño López Ansótegui <nunyo.lopez>
Component: SerialsAssignee: Nuño López Ansótegui <nunyo.lopez>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: colin.campbell, gmcharlt, julian.maurice
Version: 3.14   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on: 11261    
Bug Blocks:    
Attachments: Bug 11309 - Duplicated patterns when subscription table is updated
[SIGNED-OFF] Bug 11309: Duplicated patterns when subscription table is updated
Bug 11309: Duplicated patterns when subscription table is updated

Description Nuño López Ansótegui 2013-11-26 18:20:00 UTC
When you update the subscription table, checking patterns has a bad behaviour because this process compares patterns (new versus just created) without considering NULL values. The result is a lot of patterns duplicated in 'subscription_numberpatterns' table.
Comment 1 Nuño López Ansótegui 2013-11-26 18:22:27 UTC Comment hidden (obsolete)
Comment 2 Julian Maurice 2014-01-08 08:19:54 UTC Comment hidden (obsolete)
Comment 3 Julian Maurice 2014-01-08 08:29:58 UTC
Steps to reproduce the problem:
1/ Install Koha 3.12
2/ Create some subscriptions. Ensure you have at least two subscriptions with the same numbering pattern, with one of the keys everyX/addX/whenmorethanX/settoX set to NULL
3/ Remember this numbering pattern.
4/ Upgrade to 3.14
5/ Run updatedatabase.pl
6/ The numbering pattern is duplicated

Now repeat steps 1 to 4, then apply the patch and run updatedatabase.pl. Numbering pattern should not be duplicated.
Comment 4 Julian Maurice 2014-01-08 09:45:42 UTC
Maybe this need another patch to remove already created duplicates (maybe only those whose name starts with 'Backup pattern') ?
Comment 5 Kyle M Hall (khall) 2014-01-17 13:30:57 UTC
Created attachment 24495 [details] [review]
Bug 11309: Duplicated patterns when subscription table is updated

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 6 Galen Charlton 2014-05-05 03:40:41 UTC
Pushed to master.  Thanks, Nuño!