Summary: | Add a link to basketgroup in basket detail page | ||
---|---|---|---|
Product: | Koha | Reporter: | Mathieu Saby <mathsabypro> |
Component: | Acquisitions | Assignee: | Mathieu Saby <mathsabypro> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | gmcharlt |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20892 | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
[PATCH] Bug 11429 : Add a link to basketgroup in basket detail page
[PATCH] Bug 11429 : Add a link to basketgroup in basket detail page Bug 11429 : Add a link to basketgroup in basket detail page Bug 11429: Manage display for basketgroup without name [PASSED QA] Bug 11429 : Add a link to basketgroup in basket detail page [PASSED QA] Bug 11429: Manage display for basketgroup without name |
Description
Mathieu Saby
2013-12-19 21:49:06 UTC
Created attachment 23702 [details] [review] [PATCH] Bug 11429 : Add a link to basketgroup in basket detail page If a basket is in a closed basketgroup, the basketgroup name is currently displayed. This patch adds a link arround the name, so that the librarian could easily go to the basketgroup from the basket. Test: Display a closed basket that is grouped in a basketgroup Check the name of the basketgroup is now a link Click on the link and check you are seeing information about the right basketgroup Created attachment 23753 [details] [review] [PATCH] Bug 11429 : Add a link to basketgroup in basket detail page If a basket is in a closed basketgroup, the basketgroup name is currently displayed. This patch adds a link around the basketgroup name if the librarian has permission to manage basketgroups. Test: A. With a librarian with rights for managing basketgroups Display a closed basket that is grouped in a basketgroup Check the name of the basketgroup is now a link Click on the link and check you are seeing information about the right basketgroup B. With a librarian WITHOUT rights for managing basketgroups Display a closed basket that is grouped in a basketgroup Check the name of the basketgroup is not a link Created attachment 24511 [details] [review] Bug 11429 : Add a link to basketgroup in basket detail page If a basket is in a closed basketgroup, the basketgroup name is currently displayed. This patch adds a link around the basketgroup name if the librarian has permission to manage basketgroups. Test: A. With a librarian with rights for managing basketgroups Display a closed basket that is grouped in a basketgroup Check the name of the basketgroup is now a link Click on the link and check you are seeing information about the right basketgroup B. With a librarian WITHOUT rights for managing basketgroups Display a closed basket that is grouped in a basketgroup Check the name of the basketgroup is not a link Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Created attachment 24513 [details] [review] Bug 11429: Manage display for basketgroup without name If a basketgroup does not have a name, the link was ' (closed)' Now it is "Basket group no. ID (closed)". This is used on the acqui/basketgroup.pl?booksellerid=XX page Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Created attachment 24553 [details] [review] [PASSED QA] Bug 11429 : Add a link to basketgroup in basket detail page If a basket is in a closed basketgroup, the basketgroup name is currently displayed. This patch adds a link around the basketgroup name if the librarian has permission to manage basketgroups. Test: A. With a librarian with rights for managing basketgroups Display a closed basket that is grouped in a basketgroup Check the name of the basketgroup is now a link Click on the link and check you are seeing information about the right basketgroup B. With a librarian WITHOUT rights for managing basketgroups Display a closed basket that is grouped in a basketgroup Check the name of the basketgroup is not a link Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Created attachment 24554 [details] [review] [PASSED QA] Bug 11429: Manage display for basketgroup without name If a basketgroup does not have a name, the link was ' (closed)' Now it is "Basket group no. ID (closed)". This is used on the acqui/basketgroup.pl?booksellerid=XX page Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Adds a link to the basket group page on the basket summary page. The link only appears when the basket group is closed. Pushed to master. Thanks, Mathieu! |