Now that bug 9807 is pushed, we can display closed basketgroups without reopening them. We can use this new behavior for safely making links to basketgroups in basket detail page. M. Saby
Created attachment 23702 [details] [review] [PATCH] Bug 11429 : Add a link to basketgroup in basket detail page
If a basket is in a closed basketgroup, the basketgroup name is currently displayed. This patch adds a link arround the name, so that the librarian could easily go to the basketgroup from the basket. Test: Display a closed basket that is grouped in a basketgroup Check the name of the basketgroup is now a link Click on the link and check you are seeing information about the right basketgroup
Created attachment 23753 [details] [review] [PATCH] Bug 11429 : Add a link to basketgroup in basket detail page If a basket is in a closed basketgroup, the basketgroup name is currently displayed. This patch adds a link around the basketgroup name if the librarian has permission to manage basketgroups. Test: A. With a librarian with rights for managing basketgroups Display a closed basket that is grouped in a basketgroup Check the name of the basketgroup is now a link Click on the link and check you are seeing information about the right basketgroup B. With a librarian WITHOUT rights for managing basketgroups Display a closed basket that is grouped in a basketgroup Check the name of the basketgroup is not a link
Created attachment 24511 [details] [review] Bug 11429 : Add a link to basketgroup in basket detail page If a basket is in a closed basketgroup, the basketgroup name is currently displayed. This patch adds a link around the basketgroup name if the librarian has permission to manage basketgroups. Test: A. With a librarian with rights for managing basketgroups Display a closed basket that is grouped in a basketgroup Check the name of the basketgroup is now a link Click on the link and check you are seeing information about the right basketgroup B. With a librarian WITHOUT rights for managing basketgroups Display a closed basket that is grouped in a basketgroup Check the name of the basketgroup is not a link Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 24513 [details] [review] Bug 11429: Manage display for basketgroup without name If a basketgroup does not have a name, the link was ' (closed)' Now it is "Basket group no. ID (closed)". This is used on the acqui/basketgroup.pl?booksellerid=XX page Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 24553 [details] [review] [PASSED QA] Bug 11429 : Add a link to basketgroup in basket detail page If a basket is in a closed basketgroup, the basketgroup name is currently displayed. This patch adds a link around the basketgroup name if the librarian has permission to manage basketgroups. Test: A. With a librarian with rights for managing basketgroups Display a closed basket that is grouped in a basketgroup Check the name of the basketgroup is now a link Click on the link and check you are seeing information about the right basketgroup B. With a librarian WITHOUT rights for managing basketgroups Display a closed basket that is grouped in a basketgroup Check the name of the basketgroup is not a link Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Created attachment 24554 [details] [review] [PASSED QA] Bug 11429: Manage display for basketgroup without name If a basketgroup does not have a name, the link was ' (closed)' Now it is "Basket group no. ID (closed)". This is used on the acqui/basketgroup.pl?booksellerid=XX page Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Adds a link to the basket group page on the basket summary page. The link only appears when the basket group is closed.
Pushed to master. Thanks, Mathieu!