Bug 11429 - Add a link to basketgroup in basket detail page
Summary: Add a link to basketgroup in basket detail page
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Mathieu Saby
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-19 21:49 UTC by Mathieu Saby
Modified: 2018-06-07 13:53 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
[PATCH] Bug 11429 : Add a link to basketgroup in basket detail page (1.65 KB, patch)
2013-12-19 22:04 UTC, Mathieu Saby
Details | Diff | Splinter Review
[PATCH] Bug 11429 : Add a link to basketgroup in basket detail page (2.10 KB, patch)
2013-12-22 20:36 UTC, Mathieu Saby
Details | Diff | Splinter Review
Bug 11429 : Add a link to basketgroup in basket detail page (2.12 KB, patch)
2014-01-17 15:34 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 11429: Manage display for basketgroup without name (1.97 KB, patch)
2014-01-17 15:46 UTC, Jonathan Druart
Details | Diff | Splinter Review
[PASSED QA] Bug 11429 : Add a link to basketgroup in basket detail page (2.19 KB, patch)
2014-01-19 09:59 UTC, Katrin Fischer
Details | Diff | Splinter Review
[PASSED QA] Bug 11429: Manage display for basketgroup without name (2.19 KB, patch)
2014-01-19 10:00 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Mathieu Saby 2013-12-19 21:49:06 UTC
Now that bug 9807 is pushed, we can display closed basketgroups without reopening them.
We can use this new behavior for safely making links to basketgroups in basket detail page.

M. Saby
Comment 1 Mathieu Saby 2013-12-19 22:04:03 UTC Comment hidden (obsolete)
Comment 2 Mathieu Saby 2013-12-19 22:04:12 UTC
If a basket is in a closed basketgroup, the basketgroup name is currently displayed.
This patch adds a link arround the name, so that the librarian could easily go to the basketgroup from the basket.

Test:
Display a closed basket that is grouped in a basketgroup
Check the name of the basketgroup is now a link
Click on the link and check you are seeing information about the right basketgroup
Comment 3 Mathieu Saby 2013-12-22 20:36:45 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2014-01-17 15:34:09 UTC Comment hidden (obsolete)
Comment 5 Jonathan Druart 2014-01-17 15:46:42 UTC Comment hidden (obsolete)
Comment 6 Katrin Fischer 2014-01-19 09:59:46 UTC
Created attachment 24553 [details] [review]
[PASSED QA] Bug 11429 : Add a link to basketgroup in basket detail page

If a basket is in a closed basketgroup, the basketgroup name is currently displayed.
This patch adds a link around the basketgroup name if the librarian has permission to manage basketgroups.

Test:
A. With a librarian with rights for managing basketgroups
Display a closed basket that is grouped in a basketgroup
Check the name of the basketgroup is now a link
Click on the link and check you are seeing information about the right basketgroup

B. With a librarian WITHOUT rights for managing basketgroups
Display a closed basket that is grouped in a basketgroup
Check the name of the basketgroup is not a link

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Comment 7 Katrin Fischer 2014-01-19 10:00:57 UTC
Created attachment 24554 [details] [review]
[PASSED QA] Bug 11429: Manage display for basketgroup without name

If a basketgroup does not have a name, the link was ' (closed)'
Now it is "Basket group no. ID (closed)".
This is used on the acqui/basketgroup.pl?booksellerid=XX page

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes all tests and QA script. Adds a link to the basket group page
on the basket summary page. The link only appears when the basket
group is closed.
Comment 8 Galen Charlton 2014-01-23 17:00:12 UTC
Pushed to master.  Thanks, Mathieu!