Summary: | Prevent bypassing sco timeout with print dialog | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
Component: | Self checkout | Assignee: | Marc Véron <veron> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | brendan, f.demians, jonathan.druart, julian.maurice, katrin.fischer, scrosby000, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Bug 11498 - Prevent bypassing sco timeout with print dialog
Bug 11498 - Prevent bypassing sco timeout with print dialog [PASSED QA] Bug 11498 - Prevent bypassing sco timeout with print dialog |
Description
Nicole C. Engard
2014-01-08 15:06:39 UTC
The problem with javascript in this case is that the confirm dialog box freezes runtime, meaning that the timer stops. I don't think theres a way to get it to auto close without plugins. I think the best solution would be to have it either redirect to a page containing a print preview of the receipt (which would allow the timeout check to continue) or to have a separate page for the print receipt, and close would just log out without bringing up a dialog. Anyone got any thoughts? Created attachment 47859 [details] [review] Bug 11498 - Prevent bypassing sco timeout with print dialog This patch prevents bypassing the self check timeout with the print dialog. To test: - Set syspref 'WebVasedSelfCheck' to 'Enable' - Set syspref 'SelfCheckoutReceivePrompt' to 'Show' - Set syspref 'SelfCheckTimeout' to 20 seconds - Apply patch - Go to SCO page (/cgi-bin/koha/sco/sco-main.pl) - Enter card number - Click 'Finish'. Dialog "Would you like to pritn a receipt?' appears. - Confirm printing without waiting 20 seconds => Result: Print slip, SCO page shows 'Please enter your card number' - Enter card number again - Click 'Finish'. Dialog "Would you like to pritn a receipt?' appears. - Wait > 20 seconds (value of SelfCheckTimeout) and then confirm. => Result: Message appears "Timeout while waiting for print confirmation" - Click on OK. => Result: Self checkout page refreshes (shows 'Please enter your card number') Still applies on current master. Still applies on current master. Created attachment 49562 [details] [review] Bug 11498 - Prevent bypassing sco timeout with print dialog This patch prevents bypassing the self check timeout with the print dialog. To test: - Set syspref 'WebVasedSelfCheck' to 'Enable' - Set syspref 'SelfCheckoutReceivePrompt' to 'Show' - Set syspref 'SelfCheckTimeout' to 20 seconds - Apply patch - Go to SCO page (/cgi-bin/koha/sco/sco-main.pl) - Enter card number - Click 'Finish'. Dialog "Would you like to pritn a receipt?' appears. - Confirm printing without waiting 20 seconds => Result: Print slip, SCO page shows 'Please enter your card number' - Enter card number again - Click 'Finish'. Dialog "Would you like to pritn a receipt?' appears. - Wait > 20 seconds (value of SelfCheckTimeout) and then confirm. => Result: Message appears "Timeout while waiting for print confirmation" - Click on OK. => Result: Self checkout page refreshes (shows 'Please enter your card number') Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Created attachment 49608 [details] [review] [PASSED QA] Bug 11498 - Prevent bypassing sco timeout with print dialog This patch prevents bypassing the self check timeout with the print dialog. To test: - Set syspref 'WebVasedSelfCheck' to 'Enable' - Set syspref 'SelfCheckoutReceivePrompt' to 'Show' - Set syspref 'SelfCheckTimeout' to 20 seconds - Apply patch - Go to SCO page (/cgi-bin/koha/sco/sco-main.pl) - Enter card number - Click 'Finish'. Dialog "Would you like to pritn a receipt?' appears. - Confirm printing without waiting 20 seconds => Result: Print slip, SCO page shows 'Please enter your card number' - Enter card number again - Click 'Finish'. Dialog "Would you like to pritn a receipt?' appears. - Wait > 20 seconds (value of SelfCheckTimeout) and then confirm. => Result: Message appears "Timeout while waiting for print confirmation" - Click on OK. => Result: Self checkout page refreshes (shows 'Please enter your card number') Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> https://bugs.koha-community.org/show_bug.cgi?id=11497 This improves the situation as it's no longer so easily possible to print a slip from another patron. It would be good if we also had a way to reset the summary screen in the background after the timeout so the checked out items are no longer visible. Pushed to Master - Should be in the May 2016 release. Thanks! Patch pushed to 3.22.x, will be in 3.22.6 Pushed to 3.20.x, will be in 3.20.11. |