Bug 11498 - Prevent bypassing sco timeout with print dialog
Summary: Prevent bypassing sco timeout with print dialog
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Self checkout (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Marc Véron
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-08 15:06 UTC by Nicole C. Engard
Modified: 2016-12-05 21:25 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11498 - Prevent bypassing sco timeout with print dialog (2.30 KB, patch)
2016-02-10 16:36 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 11498 - Prevent bypassing sco timeout with print dialog (2.35 KB, patch)
2016-03-24 21:43 UTC, Mirko Tietgen
Details | Diff | Splinter Review
[PASSED QA] Bug 11498 - Prevent bypassing sco timeout with print dialog (2.47 KB, patch)
2016-03-28 21:09 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2014-01-08 15:06:39 UTC
You have to click one of the options on the self check print dialog for the screen to log out. The SelfCheckTimeout system preference doesn't seem to be able to function when the print receipt question is up. So if a patron walks away without making a selection, their checkouts remain on the screen.
Comment 1 Samuel Crosby 2014-01-17 01:26:18 UTC
The problem with javascript in this case is that the confirm dialog box freezes runtime, meaning that the timer stops. I don't think theres a way to get it to auto close without plugins.

I think the best solution would be to have it either redirect to a page containing a print preview of the receipt (which would allow the timeout check to continue) or to have a separate page for the print receipt, and close would just log out without bringing up a dialog.

Anyone got any thoughts?
Comment 2 Marc Véron 2016-02-10 16:36:20 UTC Comment hidden (obsolete)
Comment 3 Marc Véron 2016-02-26 17:12:18 UTC
Still applies on current master.
Comment 4 Marc Véron 2016-03-15 16:16:39 UTC
Still applies on current master.
Comment 5 Mirko Tietgen 2016-03-24 21:43:46 UTC Comment hidden (obsolete)
Comment 6 Katrin Fischer 2016-03-28 21:09:47 UTC
Created attachment 49608 [details] [review]
[PASSED QA] Bug 11498 - Prevent bypassing sco timeout with print dialog

This patch prevents bypassing the self check timeout with the print dialog.

To test:
- Set syspref 'WebVasedSelfCheck' to 'Enable'
- Set syspref 'SelfCheckoutReceivePrompt' to 'Show'
- Set syspref 'SelfCheckTimeout' to 20 seconds
- Apply patch
- Go to SCO page (/cgi-bin/koha/sco/sco-main.pl)
- Enter card number
- Click 'Finish'. Dialog "Would you like to pritn a receipt?' appears.
- Confirm printing without waiting 20 seconds
  => Result: Print slip, SCO page shows 'Please enter your card number'
- Enter card number again
- Click 'Finish'. Dialog "Would you like to pritn a receipt?' appears.
- Wait > 20 seconds (value of SelfCheckTimeout) and then confirm.
  => Result: Message appears "Timeout while waiting for print confirmation"
- Click on OK.
  => Result: Self checkout page refreshes (shows 'Please enter your card number')

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

https://bugs.koha-community.org/show_bug.cgi?id=11497
Comment 7 Katrin Fischer 2016-03-28 21:11:04 UTC
This improves the situation as it's no longer so easily possible to print a slip from another patron. 

It would be good if we also had a way to reset the summary screen in the background after the timeout so the checked out items are no longer visible.
Comment 8 Brendan Gallagher 2016-03-31 18:53:27 UTC
Pushed to Master - Should be in the May 2016 release.  Thanks!
Comment 9 Julian Maurice 2016-04-06 13:28:42 UTC
Patch pushed to 3.22.x, will be in 3.22.6
Comment 10 Frédéric Demians 2016-04-27 15:41:33 UTC
Pushed to 3.20.x, will be in 3.20.11.