Bug 11589

Summary: Sample serial frequencies do not match template frequencies
Product: Koha Reporter: paxed <pasi.kallinen>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: NEW --- QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: gmcharlt, katrin.fischer
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:

Description paxed 2014-01-21 08:27:23 UTC
The sample serial subscription frequencies do not match the frequencies shown in OPAC or staff client.

For example, freq 1 is '2/day', but is shown as "issued every day" in OPAC/staff client. Freq 2 is '1/day', and shows up as "issued every week".
Comment 1 Owen Leonard 2019-08-09 15:07:31 UTC
Is this bug still valid?
Comment 2 Katrin Fischer 2019-08-10 20:42:25 UTC
I've found some problematic code in koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-serial-issues.tt. I am not sure this code is still making sense since our frequencies and numbering patterns are fully configurable now:

       The current subscription began on [% subscription_LOO.startdate | html %] and is issued
                                        [% IF ( subscription_LOO.periodicity1 ) %]
                                                twice per day
                                        [% END %]
                                        [% IF ( subscription_LOO.periodicity2 ) %]
                                                every day
                                        [% END %]
                                        [% IF ( subscription_LOO.periodicity3 ) %]
                                                three times per week
                                        [% END %]
                                        [% IF ( subscription_LOO.periodicity4 ) %]
                                                every week
                                        [% END %]
                                        [% IF ( subscription_LOO.periodicity5 ) %]
                                                every 2 weeks
                                        [% END %]
                                        [% IF ( subscription_LOO.periodicity6 ) %]
                                                every 3 weeks
                                        [% END %]
                                        [% IF ( subscription_LOO.periodicity7 ) %]
                                                every month
                                        [% END %]
                                        [% IF ( subscription_LOO.periodicity8 ) %]
                                                every 2 months
                                        [% END %]
                                        [% IF ( subscription_LOO.periodicity9 ) %]
                                                every quarter
                                        [% END %]
                                        [% IF ( subscription_LOO.periodicity10 ) %]
                                                twice per year
                                        [% END %]
                                        [% IF ( subscription_LOO.periodicity11 ) %]
                                                every year
                                        [% END %]
                                        [% IF ( subscription_LOO.periodicity12 ) %]
                                                every 2 years
                                        [% END %]
                                        [% IF ( subscription_LOO.periodicity13 ) %]
                                                irregularly
                                        [% END %]
                                        [% IF ( subscription_LOO.arrival1 ) %]
                                            on Monday
                                        [% END %]
                                        [% IF ( subscription_LOO.arrival2 ) %]
                                                on Tuesday
                                        [% END %]
                                        [% IF ( subscription_LOO.arrival3 ) %]
                                                on Wednesday
                                        [% END %]
                                        [% IF ( subscription_LOO.arrival4 ) %]
                                                on Thursday
                                        [% END %]
                                        [% IF ( subscription_LOO.arrival5 ) %]
                                                on Friday
                                        [% END %]
                                        [% IF ( subscription_LOO.arrival6 ) %]
                                                on Saturday
                                        [% END %]
                                        [% IF ( subscription_LOO.arrival7 ) %]
                                                on Sunday
                                        [% END %]
Comment 3 Katrin Fischer 2020-01-05 13:48:43 UTC
*** Bug 12108 has been marked as a duplicate of this bug. ***