| Summary: | Add --text option to overdue_notices similar to --html option | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Kyle M Hall (khall) <kyle> |
| Component: | Notices | Assignee: | Kyle M Hall (khall) <kyle> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, jsasse, matted-34813 |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 11598 - Add --text option to overdue_notices similar to --html option
[SIGNED-OFF] Bug 11598 - Add --text option to overdue_notices similar to --html option Bug 11598 - Add --text option to overdue_notices similar to --html option |
||
|
Description
Kyle M Hall (khall)
2014-01-22 14:50:03 UTC
Created attachment 24609 [details] [review] Bug 11598 - Add --text option to overdue_notices similar to --html option We have a number of reports of libraries that were upset by Bug 10720 being fixed! These libraries preferred this single file output, but as text only. We should bring back this behavior, but as a feature, not a bug. Test Plan: 1) Apply this patch 2) Run overdue_notices.pl --html 3) Note the output is wrapped in html tags 4) Run overdue_notices.pl --text 5) Note the same output, but not wrapped in html tags Created attachment 25668 [details] [review] [SIGNED-OFF] Bug 11598 - Add --text option to overdue_notices similar to --html option Performed test plan. Also, compared text output with and without --text Also, tested --text /tmp to see if notices file with .txt was written. Also, tested --html /tmp to see if notices file with .html was written. And that the contents looked fine. Created attachment 27017 [details] [review] Bug 11598 - Add --text option to overdue_notices similar to --html option We have a number of reports of libraries that were upset by Bug 10720 being fixed! These libraries preferred this single file output, but as text only. We should bring back this behavior, but as a feature, not a bug. Test Plan: 1) Apply this patch 2) Run overdue_notices.pl --html 3) Note the output is wrapped in html tags 4) Run overdue_notices.pl --text 5) Note the same output, but not wrapped in html tags Signed-off-by: wajasu <matted-34813@mypacks.net> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> To test, add the -n parameter. The filename generation could be refactored but not blocker. Pushed to master. Thanks, Kyle! |