Bug 11598 - Add --text option to overdue_notices similar to --html option
Summary: Add --text option to overdue_notices similar to --html option
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Notices (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Kyle M Hall
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-22 14:50 UTC by Kyle M Hall
Modified: 2015-06-04 23:33 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11598 - Add --text option to overdue_notices similar to --html option (5.79 KB, patch)
2014-01-22 14:51 UTC, Kyle M Hall
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 11598 - Add --text option to overdue_notices similar to --html option (5.85 KB, patch)
2014-02-26 16:10 UTC, wajasu
Details | Diff | Splinter Review
Bug 11598 - Add --text option to overdue_notices similar to --html option (5.99 KB, patch)
2014-04-11 12:59 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2014-01-22 14:50:03 UTC
We have a number of reports of libraries that were upset by Bug 10720 being fixed! These libraries preferred this single file output, but as text only. We should bring back this behavior, but as a feature, not a bug.
Comment 1 Kyle M Hall 2014-01-22 14:51:45 UTC Comment hidden (obsolete)
Comment 2 wajasu 2014-02-26 16:10:47 UTC Comment hidden (obsolete)
Comment 3 wajasu 2014-02-26 16:12:50 UTC
Performed test plan.

Also, compared text output with and without --text
Also, tested --text /tmp  to see if notices file with .txt was written.
Also, tested --html /tmp  to see if notices file with .html was written.
And that the contents looked fine.
Comment 4 Jonathan Druart 2014-04-11 12:59:12 UTC
Created attachment 27017 [details] [review]
Bug 11598 - Add --text option to overdue_notices similar to --html option

We have a number of reports of libraries that were upset by Bug 10720
being fixed! These libraries preferred this single file output, but as
text only. We should bring back this behavior, but as a feature, not a
bug.

Test Plan:
1) Apply this patch
2) Run overdue_notices.pl --html
3) Note the output is wrapped in html tags
4) Run overdue_notices.pl --text
5) Note the same output, but not wrapped in html tags

Signed-off-by: wajasu <matted-34813@mypacks.net>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
To test, add the -n parameter.
The filename generation could be refactored but not blocker.
Comment 5 Galen Charlton 2014-04-11 16:29:51 UTC
Pushed to master.  Thanks, Kyle!