Bug 11643

Summary: DelBiblio does not cancel future holds, it just deletes them
Product: Koha Reporter: Galen Charlton <gmcharlt>
Component: Hold requestsAssignee: Bugs List <koha-bugs>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: gmcharlt, m.de.rooy, nick, veron
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:

Description Galen Charlton 2014-01-30 16:53:59 UTC
DelBiblio() currently does not retrieve future holds, and consequently does not call CancelReserve().  The consequences of this are minor, as it just means that old_reserves doesn't get a copy of deleted future holds (instead, the future holds are deleted via the FK constraint), but this could be a problem in the future if (say) CancelReserve() gets extended to initiate sending hold cancellation notices.

An argument could be made that the default value of the all_dates parameter to GetReservesFromBiblionumber should be true, not false.  If so, all_dates might be better named 'show_only_current_holds' or the like.
Comment 1 Nick Clemens 2021-01-29 12:01:01 UTC
DelBiblio calls Koha->holds - this includes future holds