Bug 11643 - DelBiblio does not cancel future holds, it just deletes them
Summary: DelBiblio does not cancel future holds, it just deletes them
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-30 16:53 UTC by Galen Charlton
Modified: 2021-12-13 21:08 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Galen Charlton 2014-01-30 16:53:59 UTC
DelBiblio() currently does not retrieve future holds, and consequently does not call CancelReserve().  The consequences of this are minor, as it just means that old_reserves doesn't get a copy of deleted future holds (instead, the future holds are deleted via the FK constraint), but this could be a problem in the future if (say) CancelReserve() gets extended to initiate sending hold cancellation notices.

An argument could be made that the default value of the all_dates parameter to GetReservesFromBiblionumber should be true, not false.  If so, all_dates might be better named 'show_only_current_holds' or the like.
Comment 1 Nick Clemens 2021-01-29 12:01:01 UTC
DelBiblio calls Koha->holds - this includes future holds