Summary: | merging authority records does not correct biblios | ||
---|---|---|---|
Product: | Koha | Reporter: | Janusz Kaczmarek <januszop> |
Component: | MARC Authority data support | Assignee: | Janusz Kaczmarek <januszop> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, jcamins |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | |||
Bug Blocks: | 12579 | ||
Attachments: |
proposed patch
Bug 11652: merging authority records does not correct biblios [PASSED QA] Bug 11652: merging authority records does not correct biblios |
Description
Janusz Kaczmarek
2014-01-31 15:27:22 UTC
Created attachment 24950 [details] [review] proposed patch When merging authority records in librarian interface biblio records linked to deleted authority are not being corrected (i.e. have still old heading and orpaned link in $9). Test plan: 1. Have two authorities in the catalogue, linked to biblio records. 2. Merge them with the new merge facility (cf. Bug 5202). 3. Have a look a the biblio record(s) previously linked to the removed authority. It should still have the old heading AND orpaned authority link in $9. 4. Apply the patch. 5. Refresh the test records (or use another set). 6. Repeat 1-3. Headings should be refreshed and the correct authid link should be in $9 now. Created attachment 24977 [details] [review] Bug 11652: merging authority records does not correct biblios When merging authority records in librarian interface biblio records linked to deleted authority are not being corrected (i.e. have still old heading and orpaned link in $9). Test plan: 1. Have two authorities in the catalogue, linked to biblio records. 2. Merge them with the new merge facility (cf. Bug 5202). 3. Have a look a the biblio record(s) previously linked to the removed authority. It should still have the old heading AND orpaned authority link in $9. 4. Apply the patch. 5. Refresh the test records (or use another set). 6. Repeat 1-3. Headings should be refreshed and the correct authid link should be in $9 now. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Janusz, I am working on this - could you check if merging 2 records from different frameworks works ok for you? I tried merging one "default" and "personal name" but the merge screen comes up empty? I am sorry, but this doesn't seem to work for me. I merged to person authority records, each linked to 2 records. After the merge, it only shows 2 linked records, while I think it should be 4. Adding Jared here cc as he is module maintainer for autorities. Aha - wrote the last comment too soon - reindexing fixed it. Created attachment 24983 [details] [review] [PASSED QA] Bug 11652: merging authority records does not correct biblios When merging authority records in librarian interface biblio records linked to deleted authority are not being corrected (i.e. have still old heading and orpaned link in $9). Test plan: 1. Have two authorities in the catalogue, linked to biblio records. 2. Merge them with the new merge facility (cf. Bug 5202). 3. Have a look a the biblio record(s) previously linked to the removed authority. It should still have the old heading AND orpaned authority link in $9. 4. Apply the patch. 5. Refresh the test records (or use another set). 6. Repeat 1-3. Headings should be refreshed and the correct authid link should be in $9 now. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Note: new record count on the authority record will show after reindexing. Another note about comment 3: I think this might have been a data problem, retested with other records and it worked ok. This is pending review by Jared. Regardless of my setting for dontmerge, this patch does not seem to do anything. Are there other system preferences I should be looking at? Jared, this patch does not depend on dontmerge, nor, most probably, on any other pref. I will try to be as straightforward as I can -- sorry if this will be too straightforward. First of all, the play is around biblio records. Authorities are OK. Now, how does you standard master Koha behave when you merge *two*different*authority* records *from*librarian*interface* (just in case: not from merge_authority.pl script) -- what do you see as $9 in the heading field in *biblio* rec. that was previously linked to the authority which has just been merged (i.e. deleted)? In my case it is the "old" $9 (of the merged = deleted authority) which is now "orphaned", i.e. there is no authority record with this authid. Which is wrong. This patch should correct this -- after applying it you should see "new" authid in $9 (and the heading field itself should be accordingly changed). (In reply to Janusz Kaczmarek from comment #10) > In my case it is the "old" $9 (of the merged = deleted authority) which is > now "orphaned", i.e. there is no authority record with this authid. Which is > wrong. > > This patch should correct this -- after applying it you should see "new" > authid in $9 (and the heading field itself should be accordingly changed). I was seeing the old authid both before and after applying this patch, but I just realized that my git repo did not have a hook to restart Plack. This works fine now that I've restarted Plack. Pushed to the bug_11652 branch mm/jcamins for merging into master. Awesome! :) Pushed to master. Thanks, Janusz! Pushed to 3.14.x, will be in 3.14.07. |