|
Description
Jonathan Druart
2014-02-04 14:11:07 UTC
Created attachment 25025 [details] [review] Bug 11678: Gather print notices: add --email parameter This patch add the ability to send generated files by email. You can specify several emails. Test plan: - same as Bug 11603 - call the script misc/cronjobs/gather_print_notices.pl with the following parameters: perl misc/cronjobs/gather_print_notices.pl /tmp/test --csv --ods --html --letter_code=CHECKIN -d=: --email="email_one@example.org" --email="email_two@example.org" check your mailbox and verify the email contain 3 attached files: 1 csv, 1 ods and 1 html The sandbox you've requested is not ready. Some problems occurred applying patches from bug 11678: <h1>Something went wrong !</h1>Applying: Bug 11678: Gather print notices: add --email parameter fatal: sha1 information is lacking or useless (misc/cronjobs/gather_print_notices.pl). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 11678: Gather print notices: add --email parameter When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. Bug 11678 - Gather print notices: send files by email 25025 - Bug 11678: Gather print notices: add --email parameter Apply? [(y)es, (n)o, (i)nteractive] Patch left in /tmp/Bug-11678-Gather-print-notices-add---email-paramet-zFtjtl.patch . I like the idea of emailing the print notices, but I'm not sure that I like the idea of using a parameter to achieve this. Wouldn't it be a better idea to send the email to the pick-up library, and failing that the KohaAdminEmailAddress? (In reply to David Cook from comment #4) > I like the idea of emailing the print notices, but I'm not sure that I like > the idea of using a parameter to achieve this. > > Wouldn't it be a better idea to send the email to the pick-up library, and > failing that the KohaAdminEmailAddress? I say this in part because it seems like needless duplication/maintenance to specify a library email address in the cronjob when it's already available to Koha. (In reply to David Cook from comment #5) > I say this in part because it seems like needless duplication/maintenance to > specify a library email address in the cronjob when it's already available > to Koha. Yes, maybe it could be done later, if someone wants. The need was not to sent an email to the library email address defined into Koha but to several other emails. Created attachment 30984 [details] [review] Bug 11678: Gather print notices: add --email parameter This patch add the ability to send generated files by email. You can specify several emails. Test plan: - same as Bug 11603 - call the script misc/cronjobs/gather_print_notices.pl with the following parameters: perl misc/cronjobs/gather_print_notices.pl /tmp/test --csv --ods --html --letter_code=CHECKIN -d=: --email="email_one@example.org" --email="email_two@example.org" check your mailbox and verify the email contain 3 attached files: 1 csv, 1 ods and 1 html Created attachment 37838 [details] [review] Bug 11678: Gather print notices: add --email parameter This patch add the ability to send generated files by email. You can specify several emails. Test plan: - same as Bug 11603 - call the script misc/cronjobs/gather_print_notices.pl with the following parameters: perl misc/cronjobs/gather_print_notices.pl /tmp/test --csv --ods --html --letter_code=CHECKIN -d=: --email="email_one@example.org" --email="email_two@example.org" Signed-off-by: Frederic Demians <f.demians@tamil.fr> - Works as described. Rebased upon bug-11603. *** Bug 12810 has been marked as a duplicate of this bug. *** Documentation for the new parameter does not mention that it's repeatable. Created attachment 43581 [details] [review] Bug 11678: Gather print notices: add --email parameter Rebased on master Created attachment 43582 [details] [review] Bug 11678: Improve documentation of new parameter Say --email is repeatable Just noting: an odt export would also be very nice - with every notice on a separate page! :) Created attachment 43939 [details] [review] [PASSED QA] Bug 11678: Gather print notices: add --email parameter This patch add the ability to send generated files by email. You can specify several emails. Test plan: - same as Bug 11603 - call the script misc/cronjobs/gather_print_notices.pl with the following parameters: perl misc/cronjobs/gather_print_notices.pl /tmp/test --csv --ods --html --letter_code=CHECKIN -d=: --email="email_one@example.org" --email="email_two@example.org" Signed-off-by: Frederic Demians <f.demians@tamil.fr> - Works as desribed. Rebased upon bug-11603. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 43940 [details] [review] [PASSED QA] Bug 11678: Improve documentation of new parameter Say --email is repeatable Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 43941 [details] [review] Bug 11678: QA follow-up - Fixing some typos in the documentation Patches pushed to master. Thanks Julian and Jonathan! |